[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: KJS: Implement Object.GetOwnPropertyDescriptor & Object.DefineProperty
From: "Bernd Buschinski" <b.buschinski () googlemail ! com>
Date: 2012-05-02 20:23:57
Message-ID: 20120502202357.3789.33582 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104515/
-----------------------------------------------------------
(Updated May 2, 2012, 8:23 p.m.)
Review request for kdelibs.
Changes
-------
array_instance.cpp
more the length check for index into putDirect, as I wrongly used one put \
Object::defineOwnProperty that should be putDirect (last change)
object.cpp
getOwnPropertyDescriptor, using only getDirect will fail for prototypes, as they \
don't implement getDirect to get propertys, we have to check the getOwnPropertySlot \
and use that to get the value.
"more * inconsistency"
https://git.reviewboard.kde.org/r/104515/diff/4/?file=58277#file58277line433
which I don't understand, is still open
Description
-------
KJS: Implement Object.GetOwnPropertyDescriptor & Object.DefineProperty
This is a pretty big patch, to get Object.defineProperty perfect for ecmascript (for \
all tests that only use implemented stuff, all test that use Object.create for \
example will fail, as its not implemented)
PropertyDescriptor:
Necessary for collectiong data, this introduce new CommonIdentifiers.h, this might \
requiere to rebuild khtml against new kjs, otherwise it might cause weird crashes (at \
least for me)
object.h:
Beside from adding new getPropertyDescriptor & getOwnPropertyDescriptor & \
defineOwnProperty, the important changes are making getPropertyAttributes, \
put/get/remove-Direct virtual. Why do I need that?
Because put checks if the prototype already has property XYZ and uses it. Now imagine \
an array that got a setter-only property via a prototype. DefineProperty would try to \
use put, which uses the prototype property and it would fail. So all custom-data \
classes like Array need to implement/use put/get/remove-Direct.
object.cpp:
currently put on a setter-only property would always throw an exception, this is only \
correct for strict-mode, as we currently do not check for strict-mode it would make \
more sense to change it to default not throwing an exception.
array.cpp/h:
The old Array implementation did not store attributes for array indexes, I rewrote it \
to also store the attributes. + Bonus: also fix getOwnPropertyNames, as we now store \
attributes. + use new attributes, reject put/delete/enum if set
function.cpp (Arguments)
changed the default attributes how parameter are stored, according to ECMA 10.6.11.b
Rest is "just" the defineProperty implementation
Diffs (updated)
-----
kjs/CMakeLists.txt 1188064
kjs/CommonIdentifiers.h 8ee40e8
kjs/array_instance.h 3f2b630
kjs/array_instance.cpp fe9b8b4
kjs/function.h 3757fe8
kjs/function.cpp 5f39ae6
kjs/object.h 047c242
kjs/object.cpp c19122f
kjs/object_object.cpp 986f03f
kjs/operations.h f8a28c8
kjs/operations.cpp d4c0066
kjs/propertydescriptor.h PRE-CREATION
kjs/propertydescriptor.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/104515/diff/
Testing
-------
ecmascript & daily surfing
used valgrind on many array testcases to check for possible memleaks
Thanks,
Bernd Buschinski
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104515/">http://git.reviewboard.kde.org/r/104515/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Bernd Buschinski.</div>
<p style="color: grey;"><i>Updated May 2, 2012, 8:23 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">array_instance.cpp more the length check for index into putDirect, as I \
wrongly used one put Object::defineOwnProperty that should be putDirect (last change)
object.cpp
getOwnPropertyDescriptor, using only getDirect will fail for prototypes, as they \
don't implement getDirect to get propertys, we have to check the \
getOwnPropertySlot and use that to get the value.
"more * inconsistency"
https://git.reviewboard.kde.org/r/104515/diff/4/?file=58277#file58277line433
which I don't understand, is still open</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KJS: Implement Object.GetOwnPropertyDescriptor & \
Object.DefineProperty
This is a pretty big patch, to get Object.defineProperty perfect for ecmascript (for \
all tests that only use implemented stuff, all test that use Object.create for \
example will fail, as its not implemented)
PropertyDescriptor:
Necessary for collectiong data, this introduce new CommonIdentifiers.h, this might \
requiere to rebuild khtml against new kjs, otherwise it might cause weird crashes (at \
least for me)
object.h:
Beside from adding new getPropertyDescriptor & getOwnPropertyDescriptor & \
defineOwnProperty, the important changes are making getPropertyAttributes, \
put/get/remove-Direct virtual. Why do I need that?
Because put checks if the prototype already has property XYZ and uses it. Now imagine \
an array that got a setter-only property via a prototype. DefineProperty would try to \
use put, which uses the prototype property and it would fail. So all custom-data \
classes like Array need to implement/use put/get/remove-Direct.
object.cpp:
currently put on a setter-only property would always throw an exception, this is only \
correct for strict-mode, as we currently do not check for strict-mode it would make \
more sense to change it to default not throwing an exception.
array.cpp/h:
The old Array implementation did not store attributes for array indexes, I rewrote it \
to also store the attributes. + Bonus: also fix getOwnPropertyNames, as we now store \
attributes. + use new attributes, reject put/delete/enum if set
function.cpp (Arguments)
changed the default attributes how parameter are stored, according to ECMA 10.6.11.b
Rest is "just" the defineProperty implementation</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">ecmascript & daily surfing
used valgrind on many array testcases to check for possible memleaks</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kjs/CMakeLists.txt <span style="color: grey">(1188064)</span></li>
<li>kjs/CommonIdentifiers.h <span style="color: grey">(8ee40e8)</span></li>
<li>kjs/array_instance.h <span style="color: grey">(3f2b630)</span></li>
<li>kjs/array_instance.cpp <span style="color: grey">(fe9b8b4)</span></li>
<li>kjs/function.h <span style="color: grey">(3757fe8)</span></li>
<li>kjs/function.cpp <span style="color: grey">(5f39ae6)</span></li>
<li>kjs/object.h <span style="color: grey">(047c242)</span></li>
<li>kjs/object.cpp <span style="color: grey">(c19122f)</span></li>
<li>kjs/object_object.cpp <span style="color: grey">(986f03f)</span></li>
<li>kjs/operations.h <span style="color: grey">(f8a28c8)</span></li>
<li>kjs/operations.cpp <span style="color: grey">(d4c0066)</span></li>
<li>kjs/propertydescriptor.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kjs/propertydescriptor.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104515/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic