'Review Request: Avoid using QDialog::exec in kpasswdserver to address long standing issue'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request: Avoid using QDialog::exec in kpasswdserver to address long standing issue
From:       "Dawit Alemayehu" <adawit () kde ! org>
Date:       2012-05-01 22:36:04
Message-ID: 20120501223604.26137.95932 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104817/
-----------------------------------------------------------

Review request for KDE Runtime and David Faure.


Description
-------

The attached patch does the following:

- Use QDialog::open instead of QDialog::exec to prevent one password dialog=
 from blocking other password dialogs. This fixes the changes committed wit=
h https://git.reviewboard.kde.org/r/103245/ which allowed dialog boxes from=
 different applications to be shown so long as they are not for the same si=
te.

- Update the key under which the password is cached if the request url cont=
ains a username, but the user change it in the password dialog. IOW, do now=
 allow a password to be stored under different username than the one used t=
o access the site.

- Added the unit test listed in the TODOs along with several more that exer=
cise all of the above changes.


Diffs
-----

  kpasswdserver/tests/kpasswdservertest.cpp 38a579b =

  kpasswdserver/DESIGN 6a128f9 =

  kpasswdserver/kpasswdserver.h 66f1f57 =

  kpasswdserver/kpasswdserver.cpp b2abbd4 =


Diff: http://git.reviewboard.kde.org/r/104817/diff/


Testing
-------

Added several additional unit tests to exercise all the changes. See patch.


Thanks,

Dawit Alemayehu


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104817/">http://git.reviewboard.kde.org/r/104817/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Runtime and David Faure.</div>
<div>By Dawit Alemayehu.</div>







<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attached patch does the following:

- Use QDialog::open instead of QDialog::exec to prevent one password dialog from \
blocking other password dialogs. This fixes the changes committed with \
https://git.reviewboard.kde.org/r/103245/ which allowed dialog boxes from different \
applications to be shown so long as they are not for the same site.

- Update the key under which the password is cached if the request url contains a \
username, but the user change it in the password dialog. IOW, do now allow a password \
to be stored under different username than the one used to access the site.

- Added the unit test listed in the TODOs along with several more that exercise all \
of the above changes.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added several additional unit tests to exercise all the changes. See \
patch.</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kpasswdserver/tests/kpasswdservertest.cpp <span style="color: \
grey">(38a579b)</span></li>

 <li>kpasswdserver/DESIGN <span style="color: grey">(6a128f9)</span></li>

 <li>kpasswdserver/kpasswdserver.h <span style="color: grey">(66f1f57)</span></li>

 <li>kpasswdserver/kpasswdserver.cpp <span style="color: grey">(b2abbd4)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104817/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic