[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: bilinear scaling for khtml/imload
From: "Allan Sandfeld Jensen" <kde () carewolf ! com>
Date: 2012-05-01 7:49:53
Message-ID: 20120501074953.30444.23296 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104743/#review13194
-----------------------------------------------------------
Ship it!
Ship It!
- Allan Sandfeld Jensen
On April 30, 2012, 9:22 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104743/
> -----------------------------------------------------------
> =
> (Updated April 30, 2012, 9:22 p.m.)
> =
> =
> Review request for kdelibs.
> =
> =
> Description
> -------
> =
> Uses bilinear scaling for images. It's a bit prettier, but not much, but =
should be a reasonable tradeoff for speed.
> =
> =
> Diffs
> -----
> =
> khtml/imload/scaledimageplane.h 35fec21 =
> khtml/imload/scaledimageplane.cpp 4977201 =
> =
> Diff: http://git.reviewboard.kde.org/r/104743/diff/
> =
> =
> Testing
> -------
> =
> ran it against a couple of different images of various sizes.
> =
> =
> Screenshots
> -----------
> =
> Before
> http://git.reviewboard.kde.org/r/104743/s/547/
> After
> http://git.reviewboard.kde.org/r/104743/s/548/
> =
> =
> Thanks,
> =
> Martin Tobias Holmedahl Sandsmark
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104743/">http://git.reviewboard.kde.org/r/104743/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Allan Sandfeld</p>
<br />
<p>On April 30th, 2012, 9:22 p.m., Martin Tobias Holmedahl Sandsmark wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Martin Tobias Holmedahl Sandsmark.</div>
<p style="color: grey;"><i>Updated April 30, 2012, 9:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Uses bilinear scaling for images. It's a bit prettier, but not much, \
but should be a reasonable tradeoff for speed.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">ran it against a couple of different images of various sizes.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>khtml/imload/scaledimageplane.h <span style="color: grey">(35fec21)</span></li>
<li>khtml/imload/scaledimageplane.cpp <span style="color: \
grey">(4977201)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104743/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/104743/s/547/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/26/before_400x100.png" \
style="border: 1px black solid;" alt="Before" /></a>
<a href="http://git.reviewboard.kde.org/r/104743/s/548/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/26/after_400x100.png" \
style="border: 1px black solid;" alt="After" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic