[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Minor krazy2 warning fixes
From: "Dawit Alemayehu" <adawit () kde ! org>
Date: 2012-04-30 23:50:59
Message-ID: 20120430235059.1023.85573 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104785/
-----------------------------------------------------------
(Updated April 30, 2012, 11:50 p.m.)
Review request for kdelibs.
Changes
-------
Added few more fixes.
Description
-------
The following patch fixes the following krazy2 warnings:
- Use const references in Q_FOREACH statements where appropriate.
- Normalize yet more signal/slot connections (missing from the first go ro=
und).
- Use brackets instead of double-quotes for the 'config*' header files.
- Fix the #ifdef statements in header files to reflect the header filename.
I did this a long time ago, but never pushed upstream. As part of my spring=
clean up I want to push this local changes upstream. Any objections ?
Diffs (updated)
-----
kio/bookmarks/kbookmarkdialog.cc 713ceff =
kio/bookmarks/kbookmarkdombuilder.cc 8e0be3c =
kio/bookmarks/kbookmarkimporter.cc 08210f7 =
kio/bookmarks/kbookmarkmanager.cc d8a9cb7 =
kio/bookmarks/kbookmarkmenu.cc deb973b =
kio/bookmarks/konqbookmarkmenu.cc 4fc6be0 =
kio/kfile/kfilemetadataprovider.cpp 8caa0c2 =
kio/kfile/kfilemetadataprovider_p.h 09d924a =
kio/kfile/kfilemetadatareaderprocess.cpp 5103087 =
kio/kfile/kimagefilepreview.cpp 74ef8b7 =
kio/kio/accessmanager.cpp e535c8a =
kio/kio/chmodjob.cpp 85e0c2c =
kio/kio/job.h aeaffa2 =
kio/kio/job.cpp 5e18998 =
kio/kio/jobuidelegate.cpp 85679c2 =
kio/kio/kdesktopfileactions.cpp edf2e9c =
kio/kio/kfileitemactions.h 27ab4e3 =
kio/kio/kfileitemactions.cpp c79a434 =
kio/kio/kfilemetainfoitem.cpp 1cab458 =
kio/kio/ksambasharedata.cpp aebcb04 =
kio/kio/kurifilter.h 289b910 =
kio/kio/kurifilter.cpp 0144a2c =
kio/kio/renamedialog.cpp 11e55a9 =
kio/misc/kpac/proxyscout.cpp 0068ce7 =
kio/misc/kpac/script.cpp a595301 =
kioslave/http/kcookiejar/kcookiejar_include.h 4053a53 =
kioslave/http/tests/httpauthenticationtest.h 35b822a =
nepomuk/core/resourcedata.cpp 0a5295b =
nepomuk/query/dateparser.cpp 9bd2e1a =
nepomuk/rcgen/ontologyparser.cpp f9f8673 =
nepomuk/rcgen/property.cpp 51d9c07 =
nepomuk/types/class.cpp 0210537 =
nepomuk/types/ontology.cpp 124e88c =
nepomuk/types/ontologymanager.cpp 10d1031 =
nepomuk/types/property.cpp 06daf3c =
nepomuk/utils/datefacet.cpp 386aa00 =
Diff: http://git.reviewboard.kde.org/r/104785/diff/
Testing
-------
Thanks,
Dawit Alemayehu
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104785/">http://git.reviewboard.kde.org/r/104785/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated April 30, 2012, 11:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added few more fixes.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The following patch fixes the following krazy2 warnings:
- Use const references in Q_FOREACH statements where appropriate.
- Normalize yet more signal/slot connections (missing from the first go round).
- Use brackets instead of double-quotes for the 'config*' header files.
- Fix the #ifdef statements in header files to reflect the header filename.
I did this a long time ago, but never pushed upstream. As part of my spring clean up \
I want to push this local changes upstream. Any objections ?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kio/bookmarks/kbookmarkdialog.cc <span style="color: grey">(713ceff)</span></li>
<li>kio/bookmarks/kbookmarkdombuilder.cc <span style="color: \
grey">(8e0be3c)</span></li>
<li>kio/bookmarks/kbookmarkimporter.cc <span style="color: \
grey">(08210f7)</span></li>
<li>kio/bookmarks/kbookmarkmanager.cc <span style="color: \
grey">(d8a9cb7)</span></li>
<li>kio/bookmarks/kbookmarkmenu.cc <span style="color: grey">(deb973b)</span></li>
<li>kio/bookmarks/konqbookmarkmenu.cc <span style="color: \
grey">(4fc6be0)</span></li>
<li>kio/kfile/kfilemetadataprovider.cpp <span style="color: \
grey">(8caa0c2)</span></li>
<li>kio/kfile/kfilemetadataprovider_p.h <span style="color: \
grey">(09d924a)</span></li>
<li>kio/kfile/kfilemetadatareaderprocess.cpp <span style="color: \
grey">(5103087)</span></li>
<li>kio/kfile/kimagefilepreview.cpp <span style="color: grey">(74ef8b7)</span></li>
<li>kio/kio/accessmanager.cpp <span style="color: grey">(e535c8a)</span></li>
<li>kio/kio/chmodjob.cpp <span style="color: grey">(85e0c2c)</span></li>
<li>kio/kio/job.h <span style="color: grey">(aeaffa2)</span></li>
<li>kio/kio/job.cpp <span style="color: grey">(5e18998)</span></li>
<li>kio/kio/jobuidelegate.cpp <span style="color: grey">(85679c2)</span></li>
<li>kio/kio/kdesktopfileactions.cpp <span style="color: grey">(edf2e9c)</span></li>
<li>kio/kio/kfileitemactions.h <span style="color: grey">(27ab4e3)</span></li>
<li>kio/kio/kfileitemactions.cpp <span style="color: grey">(c79a434)</span></li>
<li>kio/kio/kfilemetainfoitem.cpp <span style="color: grey">(1cab458)</span></li>
<li>kio/kio/ksambasharedata.cpp <span style="color: grey">(aebcb04)</span></li>
<li>kio/kio/kurifilter.h <span style="color: grey">(289b910)</span></li>
<li>kio/kio/kurifilter.cpp <span style="color: grey">(0144a2c)</span></li>
<li>kio/kio/renamedialog.cpp <span style="color: grey">(11e55a9)</span></li>
<li>kio/misc/kpac/proxyscout.cpp <span style="color: grey">(0068ce7)</span></li>
<li>kio/misc/kpac/script.cpp <span style="color: grey">(a595301)</span></li>
<li>kioslave/http/kcookiejar/kcookiejar_include.h <span style="color: \
grey">(4053a53)</span></li>
<li>kioslave/http/tests/httpauthenticationtest.h <span style="color: \
grey">(35b822a)</span></li>
<li>nepomuk/core/resourcedata.cpp <span style="color: grey">(0a5295b)</span></li>
<li>nepomuk/query/dateparser.cpp <span style="color: grey">(9bd2e1a)</span></li>
<li>nepomuk/rcgen/ontologyparser.cpp <span style="color: grey">(f9f8673)</span></li>
<li>nepomuk/rcgen/property.cpp <span style="color: grey">(51d9c07)</span></li>
<li>nepomuk/types/class.cpp <span style="color: grey">(0210537)</span></li>
<li>nepomuk/types/ontology.cpp <span style="color: grey">(124e88c)</span></li>
<li>nepomuk/types/ontologymanager.cpp <span style="color: \
grey">(10d1031)</span></li>
<li>nepomuk/types/property.cpp <span style="color: grey">(06daf3c)</span></li>
<li>nepomuk/utils/datefacet.cpp <span style="color: grey">(386aa00)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104785/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic