[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Minor krazy2 warning fixes
From: "David Faure" <faure () kde ! org>
Date: 2012-04-29 19:39:52
Message-ID: 20120429193952.9602.77953 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104785/#review13102
-----------------------------------------------------------
Looks good, except for some #include changes.
- David Faure
On April 29, 2012, 6:48 p.m., Dawit Alemayehu wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104785/
> -----------------------------------------------------------
> =
> (Updated April 29, 2012, 6:48 p.m.)
> =
> =
> Review request for kdelibs.
> =
> =
> Description
> -------
> =
> The following patch fixes the following krazy2 warnings:
> =
> - Use const references in Q_FOREACH statements where appropriate.
> - Normalize yet more signal/slot connections (missing from the first go =
round).
> - Use brackets instead of double-quotes for the 'config*' header files.
> - Fix the #ifdef statements in header files to reflect the header filena=
me.
> =
> I did this a long time ago, but never pushed upstream. As part of my spri=
ng clean up I want to push this local changes upstream. Any objections ?
> =
> =
> Diffs
> -----
> =
> kio/bookmarks/kbookmarkdialog.cc 713ceff =
> kio/bookmarks/kbookmarkdombuilder.cc 8e0be3c =
> kio/bookmarks/kbookmarkimporter.cc 08210f7 =
> kio/bookmarks/kbookmarkmanager.cc d8a9cb7 =
> kio/bookmarks/kbookmarkmenu.cc deb973b =
> kio/bookmarks/konqbookmarkmenu.cc 4fc6be0 =
> kio/kfile/kfilemetadataconfigurationwidget.h 6be2a0d =
> kio/kfile/kfilemetadataprovider.cpp 8caa0c2 =
> kio/kfile/kfilemetadataprovider_p.h 09d924a =
> kio/kfile/kfilemetadatareaderprocess.cpp 5103087 =
> kio/kfile/kfilemetadatawidget.h 50ddce9 =
> kio/kfile/kimagefilepreview.cpp 74ef8b7 =
> kio/kio/chmodjob.cpp 85e0c2c =
> kio/kio/jobuidelegate.cpp 85679c2 =
> kio/kio/kautomount.h 9ca5388 =
> kio/kio/kdesktopfileactions.cpp edf2e9c =
> kio/kio/kfilemetainfoitem.cpp 1cab458 =
> kio/kio/ksambasharedata.cpp aebcb04 =
> kio/misc/kpac/proxyscout.cpp 0068ce7 =
> kio/misc/kpac/script.cpp a595301 =
> nepomuk/core/resourcedata.cpp d6b0121 =
> =
> Diff: http://git.reviewboard.kde.org/r/104785/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Dawit Alemayehu
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104785/">http://git.reviewboard.kde.org/r/104785/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, except for \
some #include changes.</pre> <br />
<p>- David</p>
<br />
<p>On April 29th, 2012, 6:48 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated April 29, 2012, 6:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The following patch fixes the following krazy2 warnings:
- Use const references in Q_FOREACH statements where appropriate.
- Normalize yet more signal/slot connections (missing from the first go round).
- Use brackets instead of double-quotes for the 'config*' header files.
- Fix the #ifdef statements in header files to reflect the header filename.
I did this a long time ago, but never pushed upstream. As part of my spring clean up \
I want to push this local changes upstream. Any objections ?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/bookmarks/kbookmarkdialog.cc <span style="color: grey">(713ceff)</span></li>
<li>kio/bookmarks/kbookmarkdombuilder.cc <span style="color: \
grey">(8e0be3c)</span></li>
<li>kio/bookmarks/kbookmarkimporter.cc <span style="color: \
grey">(08210f7)</span></li>
<li>kio/bookmarks/kbookmarkmanager.cc <span style="color: \
grey">(d8a9cb7)</span></li>
<li>kio/bookmarks/kbookmarkmenu.cc <span style="color: grey">(deb973b)</span></li>
<li>kio/bookmarks/konqbookmarkmenu.cc <span style="color: \
grey">(4fc6be0)</span></li>
<li>kio/kfile/kfilemetadataconfigurationwidget.h <span style="color: \
grey">(6be2a0d)</span></li>
<li>kio/kfile/kfilemetadataprovider.cpp <span style="color: \
grey">(8caa0c2)</span></li>
<li>kio/kfile/kfilemetadataprovider_p.h <span style="color: \
grey">(09d924a)</span></li>
<li>kio/kfile/kfilemetadatareaderprocess.cpp <span style="color: \
grey">(5103087)</span></li>
<li>kio/kfile/kfilemetadatawidget.h <span style="color: grey">(50ddce9)</span></li>
<li>kio/kfile/kimagefilepreview.cpp <span style="color: grey">(74ef8b7)</span></li>
<li>kio/kio/chmodjob.cpp <span style="color: grey">(85e0c2c)</span></li>
<li>kio/kio/jobuidelegate.cpp <span style="color: grey">(85679c2)</span></li>
<li>kio/kio/kautomount.h <span style="color: grey">(9ca5388)</span></li>
<li>kio/kio/kdesktopfileactions.cpp <span style="color: grey">(edf2e9c)</span></li>
<li>kio/kio/kfilemetainfoitem.cpp <span style="color: grey">(1cab458)</span></li>
<li>kio/kio/ksambasharedata.cpp <span style="color: grey">(aebcb04)</span></li>
<li>kio/misc/kpac/proxyscout.cpp <span style="color: grey">(0068ce7)</span></li>
<li>kio/misc/kpac/script.cpp <span style="color: grey">(a595301)</span></li>
<li>nepomuk/core/resourcedata.cpp <span style="color: grey">(d6b0121)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104785/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic