--===============7403968083290622479== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On April 15, 2012, 5:21 p.m., Sebastian Trueg wrote: > > This is actually a bug that needs to be addressed differently. Your sol= ution is simply a hack. Normally Nepomuk should not return those results at= all. The question is though: why does it? Only if we figure that out we ca= n fix it properly. > = > Lamarque Vieira Souza wrote: > I have no idea why nepomuk returns those items, it also does it in Pl= asma Desktop 4.8.2 (search for the word 'document'). I am not an expert in = nepomuk and it is very complicated to debug nepomuk's internals. If you hav= e a better idea on how to prevent those items from showing up in query resu= lts I am all ears. > = > Sebastian Trueg wrote: > I know where the problem would be located. However, I cannot reproduc= e it with 4.8.x. > = > Lamarque Vieira Souza wrote: > I can reproduce this in my notebook if I use the "Search and Launch" = desktop layout and search for "document". The undesired matches returned in= the Plasma Active image are different from the ones in my notebook. In my = notebook running Gentoo, kde sc 4.8.2 (Qt 4.8.1 if that matters) nepomuk re= turns matches "Document" (3 times), "Blog Post", "Contract", DocumentGraph"= , "Logical Media Type", "Topic", "referrencing occurrence" and "serializati= on language". The ones I cited in this review description are from the Plas= ma Active image, which uses master branch of the kde sc repos. Where do you think the problem is located? I cannot reproduce this problem = with kde sc 4.8.0 with Qt 4.7.4 in my old notebook but I can in my new note= book with kde sc 4.8.2 and Qt 4.8.1 as I wrote before. - Lamarque Vieira ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104526/#review12482 ----------------------------------------------------------- On April 9, 2012, 10:29 p.m., Lamarque Vieira Souza wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104526/ > ----------------------------------------------------------- > = > (Updated April 9, 2012, 10:29 p.m.) > = > = > Review request for KDE Runtime. > = > = > Description > ------- > = > Nepomuk runner returns matches like "global namespace", "local namespace"= and "PaginatedTextDocument" which pollutes the query's returned matches. T= his patch adds a NegationTerm to the nepomuk query to filter them. If someb= ody has a better way to prevent those matches from appearing please let me = know. > = > = > This addresses bug 284553. > http://bugs.kde.org/show_bug.cgi?id=3D284553 > = > = > Diffs > ----- > = > plasma/generic/runners/nepomuksearch/queryclientwrapper.h 48c1eaa = > plasma/generic/runners/nepomuksearch/queryclientwrapper.cpp 0b828b0 = > = > Diff: http://git.reviewboard.kde.org/r/104526/diff/ > = > = > Testing > ------- > = > Works in my Plasma Active installation. > = > = > Thanks, > = > Lamarque Vieira Souza > = > --===============7403968083290622479== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104526/

On April 15th, 2012, 5:21 p.m., Sebastian T= rueg wrote:

This is a=
ctually a bug that needs to be addressed differently. Your solution is simp=
ly a hack. Normally Nepomuk should not return those results at all. The que=
stion is though: why does it? Only if we figure that out we can fix it prop=
erly.

On April 16th, 2012, 2:20 a.m., Lamarque Vieira Souza wrote:

I have no=
 idea why nepomuk returns those items, it also does it in Plasma Desktop 4.=
8.2 (search for the word 'document'). I am not an expert in nepomuk=
 and it is very complicated to debug nepomuk's internals. If you have a=
 better idea on how to prevent those items from showing up in query results=
 I am all ears.

On April 16th, 2012, 8:45 a.m., Sebastian Trueg wrote:

I know wh=
ere the problem would be located. However, I cannot reproduce it with 4.8.x=
.

On April 16th, 2012, 11:13 a.m., Lamarque Vieira Souza wrote:

I can rep=
roduce this in my notebook if I use the "Search and Launch" deskt=
op layout and search for "document". The undesired matches return=
ed in the Plasma Active image are different from the ones in my notebook. I=
n my notebook running Gentoo, kde sc 4.8.2 (Qt 4.8.1 if that matters) nepom=
uk returns matches "Document" (3 times), "Blog Post", &=
quot;Contract", DocumentGraph", "Logical Media Type", &=
quot;Topic", "referrencing occurrence" and "serializati=
on language". The ones I cited in this review description are from the=
 Plasma Active image, which uses master branch of the kde sc repos.
Where do yo=
u think the problem is located? I cannot reproduce this problem with kde sc=
 4.8.0 with Qt 4.7.4 in my old notebook but I can in my new notebook with k=
de sc 4.8.2 and Qt 4.8.1 as I wrote before.

- Lamarque Vieira


On April 9th, 2012, 10:29 p.m., Lamarque Vieira Souza wrote:

Review request for KDE Runtime.
By Lamarque Vieira Souza.

Updated April 9, 2012, 10:29 p.m.

Descripti= on 

Nepomuk runner returns matches like "global namespace&q=
uot;, "local namespace" and "PaginatedTextDocument" whi=
ch pollutes the query's returned matches. This patch adds a NegationTer=
m to the nepomuk query to filter them. If somebody has a better way to prev=
ent those matches from appearing please let me know.

Testing <= /h1> 
Works in my Plasma Active installation.
Bugs: 284553

Diffs=

  • plasma/generic/runners/nepomuksearch/queryclientwrapper.h (48c1eaa)
  • plasma/generic/runners/nepomuksearch/queryclientwrapper.cpp (0b828b0)

View Diff
--===============7403968083290622479==--