[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: KJS/Grammar: Introduce new non-terminal IdentifierName,
From: "Maks Orlovich" <maksim () kde ! org>
Date: 2012-04-21 15:47:33
Message-ID: 20120421154733.10233.3657 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104243/#review12765
-----------------------------------------------------------
Hmm, you may have missed my reply on IRC, making this languish in the ether=
: I meant number of shift/reduce conflicts in the parser, as reported =
by bison. I am ashamed to admit that I am not able to detect LALR parsing a=
mbiguities by inspection..
- Maks Orlovich
On March 12, 2012, 9:03 p.m., Bernd Buschinski wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104243/
> -----------------------------------------------------------
> =
> (Updated March 12, 2012, 9:03 p.m.)
> =
> =
> Review request for kdelibs.
> =
> =
> Description
> -------
> =
> KJS/Grammar: Introduce new non-terminal IdentifierName,
> which allows keywords to be used as PropertyName, in Memberexps and CallE=
xpr.
> (but not yet enum,export,extends, super, because they have the same value=
RESERVED)
> =
> =
> Diffs
> -----
> =
> kjs/grammar.h 2a006df =
> kjs/grammar.cpp 32dbeae =
> kjs/grammar.y d5e835f =
> =
> Diff: http://git.reviewboard.kde.org/r/104243/diff/
> =
> =
> Testing
> -------
> =
> Tested with ecmascript262, all keyword cases pass now, except the reserve=
d ones
> =
> =
> Thanks,
> =
> Bernd Buschinski
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104243/">http://git.reviewboard.kde.org/r/104243/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, you may have missed \
my reply on IRC, making this languish in the ether: I meant number of shift/reduce \
conflicts in the parser, as reported by bison. I am ashamed to admit that I am not \
able to detect LALR parsing ambiguities by inspection..</pre> <br />
<p>- Maks</p>
<br />
<p>On March 12th, 2012, 9:03 p.m., Bernd Buschinski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Bernd Buschinski.</div>
<p style="color: grey;"><i>Updated March 12, 2012, 9:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KJS/Grammar: Introduce new non-terminal IdentifierName, which allows \
keywords to be used as PropertyName, in Memberexps and CallExpr. (but not yet \
enum,export,extends, super, because they have the same value RESERVED)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with ecmascript262, all keyword cases pass now, except the \
reserved ones</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kjs/grammar.h <span style="color: grey">(2a006df)</span></li>
<li>kjs/grammar.cpp <span style="color: grey">(32dbeae)</span></li>
<li>kjs/grammar.y <span style="color: grey">(d5e835f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104243/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic