[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: make folderview icons translucent if composite is enabled
From: Mathias_Stephan_Panzenböck <grosser.meister.morti () gmx ! net>
Date: 2012-04-19 23:29:37
Message-ID: 20120419232937.21428.91382 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101463/
-----------------------------------------------------------
(Updated April 19, 2012, 11:29 p.m.)
Review request for KDE Base Apps.
Changes
-------
I know that this won't get merged (I agree, it is a total hack), but maybe someone is \
still interested and want's to use this patch. So I rebased it on current KDE 4.8 GIT \
(=4.8.2).
Description
-------
This patch makes dragged folderview icons translucent if composite is enabled. It is \
a kinda hack that uses an event filter to find Qt's D'n'D window, clears any mask on \
it and sets the Qt::WA_TranslucentBackground attribute. I use it day to day and it \
works fine.
The proper place to fix this would be in Qt, but they wrongfully marked the bug \
report as invalid, because they think X11 does not support translucent windows: \
http://bugreports.qt.nokia.com/browse/QTBUG-8519
This addresses bug 256475.
http://bugs.kde.org/show_bug.cgi?id=256475
Diffs (updated)
-----
plasma/applets/folderview/iconview.h e648ff0
plasma/applets/folderview/iconview.cpp 3186b18
Diff: http://git.reviewboard.kde.org/r/101463/diff/
Testing
-------
Thanks,
Mathias Stephan Panzenböck
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101463/">http://git.reviewboard.kde.org/r/101463/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Mathias Stephan Panzenböck.</div>
<p style="color: grey;"><i>Updated April 19, 2012, 11:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I know that this won't get merged (I agree, it is a total hack), but \
maybe someone is still interested and want's to use this patch. So I rebased it \
on current KDE 4.8 GIT (=4.8.2).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch makes dragged folderview icons translucent if composite is \
enabled. It is a kinda hack that uses an event filter to find Qt's D'n'D \
window, clears any mask on it and sets the Qt::WA_TranslucentBackground attribute. I \
use it day to day and it works fine.
The proper place to fix this would be in Qt, but they wrongfully marked the bug \
report as invalid, because they think X11 does not support translucent windows: \
http://bugreports.qt.nokia.com/browse/QTBUG-8519</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=256475">256475</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/applets/folderview/iconview.h <span style="color: \
grey">(e648ff0)</span></li>
<li>plasma/applets/folderview/iconview.cpp <span style="color: \
grey">(3186b18)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101463/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic