[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: KJS: Implement Object.prototypeOf, Object.keys, Object.getOwnPropertyNames
From: "Bernd Buschinski" <b.buschinski () googlemail ! com>
Date: 2012-04-19 20:35:33
Message-ID: 20120419203533.11095.72203 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104511/
-----------------------------------------------------------
(Updated April 19, 2012, 8:35 p.m.)
Review request for kdelibs.
Changes
-------
Updated Array getOwnPropertyNames to 3 parameter version, so it will work a=
gain alone after this patch
(the following patch will change it again anyway, but its good to keep it w=
orking after every commit)
Description
-------
KJS: Implement Object.prototypeOf, Object.keys, Object.getOwnPropertyNames
NOTE: Array was left out on purpose, as currentl imeplementation does not s=
ave attributes (next patch will fix this)
keys&GetOwnPropertyNames requieres to change the JSObject::getOwnPropertyNa=
mes implementation,
for future use a enum is better than than a bool, maybe there will be more =
ways to include/exclude properties.
All changes for khtml/ecma/ are to silense the -Woverloaded-virtual warnings
Diffs (updated)
-----
khtml/ecma/kjs_css.h aba44b8 =
khtml/ecma/kjs_css.cpp e3e7417 =
khtml/ecma/kjs_dom.h d0433c3 =
khtml/ecma/kjs_dom.cpp 5fff7e3 =
khtml/ecma/kjs_html.h 0f3f544c =
khtml/ecma/kjs_html.cpp e3da95c =
khtml/ecma/kjs_scriptable.h af5343c =
khtml/ecma/kjs_scriptable.cpp 5d4ea68 =
kjs/JSVariableObject.h a8f01eb =
kjs/JSVariableObject.cpp b00ef76 =
kjs/array_instance.h 3f2b630 =
kjs/array_instance.cpp fe9b8b4 =
kjs/function.h 3757fe8 =
kjs/function.cpp 5f39ae6 =
kjs/object.h 047c242 =
kjs/object.cpp c19122f =
kjs/object_object.cpp 986f03f =
kjs/property_map.h 6b127ff =
kjs/property_map.cpp b2ff08e =
kjs/string_object.h e890d52 =
kjs/string_object.cpp 170e2f7 =
Diff: http://git.reviewboard.kde.org/r/104511/diff/
Testing
-------
ecma script & daily surfing
Thanks,
Bernd Buschinski
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104511/">http://git.reviewboard.kde.org/r/104511/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Bernd Buschinski.</div>
<p style="color: grey;"><i>Updated April 19, 2012, 8:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Updated Array getOwnPropertyNames to 3 parameter version, so it will \
work again alone after this patch (the following patch will change it again anyway, \
but its good to keep it working after every commit)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KJS: Implement Object.prototypeOf, Object.keys, \
Object.getOwnPropertyNames
NOTE: Array was left out on purpose, as currentl imeplementation does not save \
attributes (next patch will fix this)
keys&GetOwnPropertyNames requieres to change the JSObject::getOwnPropertyNames \
implementation, for future use a enum is better than than a bool, maybe there will be \
more ways to include/exclude properties.
All changes for khtml/ecma/ are to silense the -Woverloaded-virtual warnings</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">ecma script & daily surfing</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>khtml/ecma/kjs_css.h <span style="color: grey">(aba44b8)</span></li>
<li>khtml/ecma/kjs_css.cpp <span style="color: grey">(e3e7417)</span></li>
<li>khtml/ecma/kjs_dom.h <span style="color: grey">(d0433c3)</span></li>
<li>khtml/ecma/kjs_dom.cpp <span style="color: grey">(5fff7e3)</span></li>
<li>khtml/ecma/kjs_html.h <span style="color: grey">(0f3f544c)</span></li>
<li>khtml/ecma/kjs_html.cpp <span style="color: grey">(e3da95c)</span></li>
<li>khtml/ecma/kjs_scriptable.h <span style="color: grey">(af5343c)</span></li>
<li>khtml/ecma/kjs_scriptable.cpp <span style="color: grey">(5d4ea68)</span></li>
<li>kjs/JSVariableObject.h <span style="color: grey">(a8f01eb)</span></li>
<li>kjs/JSVariableObject.cpp <span style="color: grey">(b00ef76)</span></li>
<li>kjs/array_instance.h <span style="color: grey">(3f2b630)</span></li>
<li>kjs/array_instance.cpp <span style="color: grey">(fe9b8b4)</span></li>
<li>kjs/function.h <span style="color: grey">(3757fe8)</span></li>
<li>kjs/function.cpp <span style="color: grey">(5f39ae6)</span></li>
<li>kjs/object.h <span style="color: grey">(047c242)</span></li>
<li>kjs/object.cpp <span style="color: grey">(c19122f)</span></li>
<li>kjs/object_object.cpp <span style="color: grey">(986f03f)</span></li>
<li>kjs/property_map.h <span style="color: grey">(6b127ff)</span></li>
<li>kjs/property_map.cpp <span style="color: grey">(b2ff08e)</span></li>
<li>kjs/string_object.h <span style="color: grey">(e890d52)</span></li>
<li>kjs/string_object.cpp <span style="color: grey">(170e2f7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104511/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic