'Re: Review Request: HTTP ioslave: do not require incoming headers to have spaces after colon'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: HTTP ioslave: do not require incoming headers to have spaces after colon
From:       "Commit Hook" <null () kde ! org>
Date:       2012-04-17 17:01:25
Message-ID: 20120417170125.8976.10883 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104625/#review12590
-----------------------------------------------------------


This review has been submitted with commit 8d8e6065b584ad32be2d0ff01f071be2=
afca881f by Rolf Eike Beer to branch KDE/4.8.

- Commit Hook


On April 16, 2012, 8:30 p.m., Rolf Eike Beer wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104625/
> -----------------------------------------------------------
> =

> (Updated April 16, 2012, 8:30 p.m.)
> =

> =

> Review request for kdelibs.
> =

> =

> Description
> -------
> =

> The RfCs suggest to use a single space after the colon in HTTP headers, b=
ut any amount of whitespace is allowed. This has been fixed for Content-Dis=
position headers a while ago. Now also fix it for the other headers we expl=
icitely check here.
> =

> =

> Diffs
> -----
> =

>   kioslave/http/http.cpp f7aa857 =

> =

> Diff: http://git.reviewboard.kde.org/r/104625/diff/
> =

> =

> Testing
> -------
> =

> Still compiles and I see no breakage.
> =

> =

> Thanks,
> =

> Rolf Eike Beer
> =

>


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104625/">http://git.reviewboard.kde.org/r/104625/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 8d8e6065b584ad32be2d0ff01f071be2afca881f by Rolf Eike Beer to \
branch KDE/4.8.</pre>  <br />







<p>- Commit</p>


<br />
<p>On April 16th, 2012, 8:30 p.m., Rolf Eike Beer wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By Rolf Eike Beer.</div>


<p style="color: grey;"><i>Updated April 16, 2012, 8:30 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The RfCs suggest to use a single space after the colon in HTTP headers, \
but any amount of whitespace is allowed. This has been fixed for Content-Disposition \
headers a while ago. Now also fix it for the other headers we explicitely check \
here.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Still compiles and I see no breakage.</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kioslave/http/http.cpp <span style="color: grey">(f7aa857)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104625/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic