[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Change Online help icon KHelpcenter
From: "Albert Astals Cid" <tsdgeos () terra ! es>
Date: 2012-04-17 16:31:58
Message-ID: 20120417163158.5425.48178 () vidsolbach ! de
[Download RAW message or body]
> On April 17, 2012, 1:45 p.m., Sebastian K=C3=BCgler wrote:
> > This change is wrong, as the menu entry has nothing to do with the sema=
ntic meaning of the icon, and the icon is not named according to the icon s=
pec.
> > =
> > So the correct icon is already set here, if its look doesn't match, the=
n that icon would need to be fixed. In this case, I assume you mean to bett=
er reflect the "online" part in the name, and I agree that it's not reflect=
ed in the name. Question is: does it matter where the help is located? (Sur=
ely does if the user is offline, but in general ... I think the "help!" par=
t is important, not the "online" part.
+1
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104621/#review12573
-----------------------------------------------------------
On April 16, 2012, 5:28 p.m., Maarten De Meyer wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104621/
> -----------------------------------------------------------
> =
> (Updated April 16, 2012, 5:28 p.m.)
> =
> =
> Review request for KDE Runtime and Cornelius Schumacher.
> =
> =
> Description
> -------
> =
> Changes the 'Online help' icon in the navigation to a more fitting one.(i=
mho)
> =
> =
> Diffs
> -----
> =
> khelpcenter/plugins/onlinehelp.desktop 540f83f =
> =
> Diff: http://git.reviewboard.kde.org/r/104621/diff/
> =
> =
> Testing
> -------
> =
> compiled and run, works fine
> =
> =
> Thanks,
> =
> Maarten De Meyer
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104621/">http://git.reviewboard.kde.org/r/104621/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 17th, 2012, 1:45 p.m., <b>Sebastian \
Kügler</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This change is wrong, as the menu entry has nothing to do with the \
semantic meaning of the icon, and the icon is not named according to the icon spec.
So the correct icon is already set here, if its look doesn't match, then that \
icon would need to be fixed. In this case, I assume you mean to better reflect the \
"online" part in the name, and I agree that it's not reflected in the \
name. Question is: does it matter where the help is located? (Surely does if the user \
is offline, but in general ... I think the "help!" part is important, not \
the "online" part.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">+1</pre> <br />
<p>- Albert</p>
<br />
<p>On April 16th, 2012, 5:28 p.m., Maarten De Meyer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime and Cornelius Schumacher.</div>
<div>By Maarten De Meyer.</div>
<p style="color: grey;"><i>Updated April 16, 2012, 5:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Changes the 'Online help' icon in the navigation to a more \
fitting one.(imho)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiled and run, works fine</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>khelpcenter/plugins/onlinehelp.desktop <span style="color: \
grey">(540f83f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104621/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic