[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Ensure authentication data is cached properly in Dolphin
From: "Peter Penz" <peter.penz19 () gmail ! com>
Date: 2012-04-16 21:07:44
Message-ID: 20120416210744.6735.76458 () vidsolbach ! de
[Download RAW message or body]
> On April 16, 2012, 2:03 p.m., Peter Penz wrote:
> > Thanks for the patch, I've not been aware that this caching-issue can b=
e solved like this :-) I guess this patch has not been applied to the lates=
t master: DolphinView does not have a dir-lister anymore (it has been moved=
to KFileItemModel). Anyhow: Please just let me rebase the patch myself so =
that I can catch all cases - I'll push the patch to master during the next =
days.
> =
> Dawit Alemayehu wrote:
> Ahh indeed. I forgot to update kde-baseapps before creating the patch=
. :( As far as not being aware of resolving password caching issues this w=
as, I guess that is my failure for not informing people about such things. =
I will have to start blogging about such issues in the future. Anyhow, I wi=
ll let you deal with it.
> =
> BTW, on a related not, is it a good idea to call KDirLister from a KI=
O slave as it is currently being done in src/search/filenamesearchprotocol.=
cpp ? After all KDirLister itself relies on KIO itself. Why not simply use =
QDir::entryList or QDir::entryInfoList ? Since ioslaves are run in a differ=
ent process, the fact that those two functions are blocking functions won't=
much matter.
Regarding the KDirLister using in the filenamesearchprotocol: The reason th=
at I did it this way was that it should be possible to also do a search e.g=
. on a ftp-repository. Are there technical reasons or risks when doing it t=
his way? I initially was unsure whether this can work at all, but it turned=
out to run very smooth.
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104614/#review12509
-----------------------------------------------------------
On April 16, 2012, 1:26 p.m., Dawit Alemayehu wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104614/
> -----------------------------------------------------------
> =
> (Updated April 16, 2012, 1:26 p.m.)
> =
> =
> Review request for KDE Base Apps and Peter Penz.
> =
> =
> Description
> -------
> =
> The attached patch sets the main window on the main directory lister in D=
olphinView and KIO jobs in DolphinMainWindow to ensure that login data for =
remote protocols such as sftp, ftp are cached properly for the duration of =
the application. Otherwise, the end user is going to end up being unnecessa=
rily re-prompted to enter password login information.
> =
> Please note that this patch does not address every use of KIO or KDirList=
er in Dolphin. There are other places in Dolphin's code where directory lis=
ters and/or jobs are used without setting the main window.
> =
> =
> Diffs
> -----
> =
> dolphin/src/dolphinmainwindow.cpp 947db77 =
> dolphin/src/views/dolphinview.cpp 78fd56d =
> =
> Diff: http://git.reviewboard.kde.org/r/104614/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Dawit Alemayehu
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104614/">http://git.reviewboard.kde.org/r/104614/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 16th, 2012, 2:03 p.m., <b>Peter Penz</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for \
the patch, I've not been aware that this caching-issue can be solved like this \
:-) I guess this patch has not been applied to the latest master: DolphinView does \
not have a dir-lister anymore (it has been moved to KFileItemModel). Anyhow: Please \
just let me rebase the patch myself so that I can catch all cases - I'll push the \
patch to master during the next days.</pre> </blockquote>
<p>On April 16th, 2012, 2:31 p.m., <b>Dawit Alemayehu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ahh indeed. I forgot to \
update kde-baseapps before creating the patch. :( As far as not being aware of \
resolving password caching issues this was, I guess that is my failure for not \
informing people about such things. I will have to start blogging about such issues \
in the future. Anyhow, I will let you deal with it.
BTW, on a related not, is it a good idea to call KDirLister from a KIO slave as it is \
currently being done in src/search/filenamesearchprotocol.cpp ? After all KDirLister \
itself relies on KIO itself. Why not simply use QDir::entryList or \
QDir::entryInfoList ? Since ioslaves are run in a different process, the fact that \
those two functions are blocking functions won't much matter.</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Regarding the KDirLister \
using in the filenamesearchprotocol: The reason that I did it this way was that it \
should be possible to also do a search e.g. on a ftp-repository. Are there technical \
reasons or risks when doing it this way? I initially was unsure whether this can work \
at all, but it turned out to run very smooth.</pre> <br />
<p>- Peter</p>
<br />
<p>On April 16th, 2012, 1:26 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps and Peter Penz.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated April 16, 2012, 1:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attached patch sets the main window on the main directory lister in \
DolphinView and KIO jobs in DolphinMainWindow to ensure that login data for remote \
protocols such as sftp, ftp are cached properly for the duration of the application. \
Otherwise, the end user is going to end up being unnecessarily re-prompted to enter \
password login information.
Please note that this patch does not address every use of KIO or KDirLister in \
Dolphin. There are other places in Dolphin's code where directory listers and/or \
jobs are used without setting the main window.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(947db77)</span></li>
<li>dolphin/src/views/dolphinview.cpp <span style="color: \
grey">(78fd56d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104614/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic