[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)
From: "makis marimpis" <makhsm () gmail ! com>
Date: 2012-04-12 8:23:54
Message-ID: 20120412082354.3759.21327 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104428/
-----------------------------------------------------------
(Updated April 12, 2012, 8:23 a.m.)
Review request for KDE Base Apps, KDE Runtime, Plasma, and Ivan Čukić.
Changes
-------
Replaced the "QTimer::singleShot" call, with "QMetaObject::invokeMethod(this, \
"realInit", Qt::QueuedConnection)" - works just fine :D
Description
-------
(follows discarded review: 104391)
The plugin adds global keyboard shortcuts for changing the activity.
Defaults start from Qt::MetaModifier + Qt::Key_F1.
Initially, this functionality was implemented (without correct results) using \
KActitivities::Controller. Using DBus seems fine, just that... it forces kamd to \
start with 3-4 seconds delay - so it really needs modification/and i would like more \
guidance related to dbus :D. Other than that, feedback is needed.
This addresses bugs 265069 and 273467.
http://bugs.kde.org/show_bug.cgi?id=265069
http://bugs.kde.org/show_bug.cgi?id=273467
Diffs (updated)
-----
service/plugins/CMakeLists.txt 3e965c0a201a7eee2c9868fcf163cf55af636858
service/plugins/globalshortcuts/CMakeLists.txt PRE-CREATION
service/plugins/globalshortcuts/activitymanager-plugin-globalshortcuts.desktop \
PRE-CREATION service/plugins/globalshortcuts/globalshortcuts.h PRE-CREATION
service/plugins/globalshortcuts/globalshortcuts.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/104428/diff/
Testing
-------
Logged in.
Used the default shortcuts to switch activities.
It works!
Thanks,
makis marimpis
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104428/">http://git.reviewboard.kde.org/r/104428/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps, KDE Runtime, Plasma, and Ivan Čukić.</div>
<div>By makis marimpis.</div>
<p style="color: grey;"><i>Updated April 12, 2012, 8:23 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Replaced the "QTimer::singleShot" call, with \
"QMetaObject::invokeMethod(this, "realInit", \
Qt::QueuedConnection)" - works just fine :D</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">(follows discarded review: 104391)
The plugin adds global keyboard shortcuts for changing the activity.
Defaults start from Qt::MetaModifier + Qt::Key_F1.
Initially, this functionality was implemented (without correct results) using \
KActitivities::Controller. Using DBus seems fine, just that... it forces kamd to \
start with 3-4 seconds delay - so it really needs modification/and i would like more \
guidance related to dbus :D. Other than that, feedback is needed. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Logged in. Used the default shortcuts to switch activities.
It works!</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=265069">265069</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=273467">273467</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>service/plugins/CMakeLists.txt <span style="color: \
grey">(3e965c0a201a7eee2c9868fcf163cf55af636858)</span></li>
<li>service/plugins/globalshortcuts/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>service/plugins/globalshortcuts/activitymanager-plugin-globalshortcuts.desktop \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>service/plugins/globalshortcuts/globalshortcuts.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>service/plugins/globalshortcuts/globalshortcuts.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104428/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic