[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)
From: "Lamarque Vieira Souza" <lamarque () kde ! org>
Date: 2012-04-10 9:48:31
Message-ID: 20120410094831.19955.70841 () vidsolbach ! de
[Download RAW message or body]
> On April 4, 2012, 5:13 p.m., Lamarque Vieira Souza wrote:
> > service/plugins/globalshortcuts/globalshortcuts.cpp, line 41
> > <http://git.reviewboard.kde.org/r/104428/diff/4/?file=55580#file55580line41>
> >
> > Maybe the slowness has nothing to do with your patch. Last weekend I was \
> > debugging a crash in Bluedevil (when I turn off my bluetooth controller). I had \
> > to restart kded4 to do some tests and I noticed that while kded is loading its \
> > modules the whole desktop freezes.
> > Usually the splash screen hides this problem, in my case there were no splash \
> > screen since I restarted only kded4.
>
> makis marimpis wrote:
> Hm, in every case i tried the plugin by restarting my kde session.
> Without the plugin, all icons in the loading screen, load (doh) almost \
> simultaneously. When the plugin kicks in all icons load as before (fast) - but it \
> stops (for a long time) when loading (what i assume it is) the plasma desktop (the \
> icon before the enormous K)...
> Is there some Qt way to do some kind of profiling in KDE?
>
> makis marimpis wrote:
> If the DBus slowness thing, is related to Plasma, should i wait until it is fixed \
> somehow to the next point release? Or, the "modifying SharedInfo" answer could also \
> be accepted (as long as it is compatible with the master branch)?
This plugin is loaded in EventProcessor's constructor, which is called from \
ActivityManager's constructor, so we have a chicken and egg problem here that may be \
the cause of the delay. This plugin tries to contact ActivityManager through dbus to \
list the current list of activities but ActivityManager loads the list from disk \
after allocating the EventProcessor object. You can try adding a slot \
GlobalShortcutsPlugin::realInit() containg everything that is in \
GlobalShortcutsPlugin::init() today and call it from GlobalShortcutsPlugin::init() \
using "QTimer::singleShot(1000, this, SLOT(realInit()));". That will make sure \
ActivityManager is already allocated when the plugin is initialized.
- Lamarque Vieira
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104428/#review12169
-----------------------------------------------------------
On April 4, 2012, 6:56 a.m., makis marimpis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104428/
> -----------------------------------------------------------
>
> (Updated April 4, 2012, 6:56 a.m.)
>
>
> Review request for KDE Base Apps, KDE Runtime, Plasma, and Ivan Čukić.
>
>
> Description
> -------
>
> (follows discarded review: 104391)
>
> The plugin adds global keyboard shortcuts for changing the activity.
> Defaults start from Qt::MetaModifier + Qt::Key_F1.
>
> Initially, this functionality was implemented (without correct results) using \
> KActitivities::Controller. Using DBus seems fine, just that... it forces kamd to \
> start with 3-4 seconds delay - so it really needs modification/and i would like \
> more guidance related to dbus :D. Other than that, feedback is needed.
>
>
> This addresses bugs 265069 and 273467.
> http://bugs.kde.org/show_bug.cgi?id=265069
> http://bugs.kde.org/show_bug.cgi?id=273467
>
>
> Diffs
> -----
>
> service/plugins/CMakeLists.txt 3e965c0a201a7eee2c9868fcf163cf55af636858
> service/plugins/globalshortcuts/CMakeLists.txt PRE-CREATION
> service/plugins/globalshortcuts/activitymanager-plugin-globalshortcuts.desktop \
> PRE-CREATION service/plugins/globalshortcuts/globalshortcuts.h PRE-CREATION
> service/plugins/globalshortcuts/globalshortcuts.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/104428/diff/
>
>
> Testing
> -------
>
> Logged in.
> Used the default shortcuts to switch activities.
> It works!
>
>
> Thanks,
>
> makis marimpis
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104428/">http://git.reviewboard.kde.org/r/104428/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 4th, 2012, 5:13 p.m., <b>Lamarque Vieira \
Souza</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/104428/diff/4/?file=55580#file55580line41" \
style="color: black; font-weight: bold; text-decoration: \
underline;">service/plugins/globalshortcuts/globalshortcuts.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">GlobalShortcutsPlugin::~GlobalShortcutsPlugin()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">41</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">bool</span> <span class="n">GlobalShortcutsPlugin</span><span \
class="o">::</span><span class="n">init</span><span class="p">()</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe the slowness has \
nothing to do with your patch. Last weekend I was debugging a crash in Bluedevil \
(when I turn off my bluetooth controller). I had to restart kded4 to do some tests \
and I noticed that while kded is loading its modules the whole desktop freezes.
Usually the splash screen hides this problem, in my case there were no splash screen \
since I restarted only kded4.</pre> </blockquote>
<p>On April 5th, 2012, 6:02 p.m., <b>makis marimpis</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm, in every case i \
tried the plugin by restarting my kde session. Without the plugin, all icons in the \
loading screen, load (doh) almost simultaneously. When the plugin kicks in all icons \
load as before (fast) - but it stops (for a long time) when loading (what i assume it \
is) the plasma desktop (the icon before the enormous K)...
Is there some Qt way to do some kind of profiling in KDE?</pre>
</blockquote>
<p>On April 10th, 2012, 6:56 a.m., <b>makis marimpis</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If the DBus slowness \
thing, is related to Plasma, should i wait until it is fixed somehow to the next \
point release? Or, the "modifying SharedInfo" answer could also be accepted \
(as long as it is compatible with the master branch)?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This plugin \
is loaded in EventProcessor's constructor, which is called from \
ActivityManager's constructor, so we have a chicken and egg problem here that may \
be the cause of the delay. This plugin tries to contact ActivityManager through dbus \
to list the current list of activities but ActivityManager loads the list from disk \
after allocating the EventProcessor object. You can try adding a slot \
GlobalShortcutsPlugin::realInit() containg everything that is in \
GlobalShortcutsPlugin::init() today and call it from GlobalShortcutsPlugin::init() \
using "QTimer::singleShot(1000, this, SLOT(realInit()));". That will make \
sure ActivityManager is already allocated when the plugin is initialized.</pre> <br \
/>
<p>- Lamarque Vieira</p>
<br />
<p>On April 4th, 2012, 6:56 a.m., makis marimpis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps, KDE Runtime, Plasma, and Ivan Čukić.</div>
<div>By makis marimpis.</div>
<p style="color: grey;"><i>Updated April 4, 2012, 6:56 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">(follows discarded review: 104391)
The plugin adds global keyboard shortcuts for changing the activity.
Defaults start from Qt::MetaModifier + Qt::Key_F1.
Initially, this functionality was implemented (without correct results) using \
KActitivities::Controller. Using DBus seems fine, just that... it forces kamd to \
start with 3-4 seconds delay - so it really needs modification/and i would like more \
guidance related to dbus :D. Other than that, feedback is needed. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Logged in. Used the default shortcuts to switch activities.
It works!</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=265069">265069</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=273467">273467</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>service/plugins/CMakeLists.txt <span style="color: \
grey">(3e965c0a201a7eee2c9868fcf163cf55af636858)</span></li>
<li>service/plugins/globalshortcuts/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>service/plugins/globalshortcuts/activitymanager-plugin-globalshortcuts.desktop \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>service/plugins/globalshortcuts/globalshortcuts.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>service/plugins/globalshortcuts/globalshortcuts.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104428/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic