[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: KJS: Extend strictEqual check for numbers by NaN and signbit check
From:       Maksim Orlovich <mo85 () cornell ! edu>
Date:       2012-03-22 15:27:26
Message-ID: CAOHCnGd2b-cL_d_BhUYwuecc8vr3josBuk69Ai0OWdwmZkYbNQ () mail ! gmail ! com
[Download RAW message or body]

This looks wrong to me; strictEqual is used for ===, which is defined
in 11.9.6, and doesn't do any freaky deviations from IEEE FP. You'll
likely need a separate version for SameValue proper.


On 3/21/12, Bernd Buschinski <b.buschinski@googlemail.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104358/
> -----------------------------------------------------------
>
> (Updated March 22, 2012, 12:41 a.m.)
>
>
> Review request for kdelibs.
>
>
> Changes
> -------
>
> Whoops sorry, wrong/old version uploaded
>  - now really check for NaN using isNan
>
>
> Description
> -------
>
> In c++ NAN == NAN return false, true in javascript 9.12 Step 4.a
> also +0 == -0 is true in c++, false in javascript 9.12 Step 4.b (same for -0
> == +0 , Step 4c)
>
>
> Diffs (updated)
> -----
>
>   kjs/operations.cpp d4c0066
>
> Diff: http://git.reviewboard.kde.org/r/104358/diff/
>
>
> Testing
> -------
>
> Tesed via ecmascript, fixes some tests that rely on +0 not beeing the same
> as -0
>
>
> Thanks,
>
> Bernd Buschinski
>
>
[prev in list] [next in list] [prev in thread] [next in thread]