'Review Request: Set the parent widget in KIO::SlaveInterface::messageBox'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request: Set the parent widget in KIO::SlaveInterface::messageBox
From:       "Dawit Alemayehu" <adawit () kde ! org>
Date:       2012-03-20 19:14:03
Message-ID: 20120320191403.28595.47431 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104351/
-----------------------------------------------------------

Review request for kdelibs.


Description
-------

This patch sets the top level window that should be used when displaying me=
ssage boxes in KIO::SlaveInterface. This is the first step into eliminating=
 those multiple message boxes that are popped up because of the out-process=
 design of KIO. Note that this is not the actual resolution, but the first =
step.


Diffs
-----

  kio/kio/scheduler.cpp 8d144bb =

  kio/kio/slaveinterface.h 3cdc2ae =

  kio/kio/slaveinterface.cpp d2f9f93 =

  kio/kio/slaveinterface_p.h e2ccfe0 =


Diff: http://git.reviewboard.kde.org/r/104351/diff/


Testing
-------


Thanks,

Dawit Alemayehu


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104351/">http://git.reviewboard.kde.org/r/104351/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By Dawit Alemayehu.</div>







<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch sets the top level window that should be used when displaying \
message boxes in KIO::SlaveInterface. This is the first step into eliminating those \
multiple message boxes that are popped up because of the out-process design of KIO. \
Note that this is not the actual resolution, but the first step.</pre>  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kio/kio/scheduler.cpp <span style="color: grey">(8d144bb)</span></li>

 <li>kio/kio/slaveinterface.h <span style="color: grey">(3cdc2ae)</span></li>

 <li>kio/kio/slaveinterface.cpp <span style="color: grey">(d2f9f93)</span></li>

 <li>kio/kio/slaveinterface_p.h <span style="color: grey">(e2ccfe0)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104351/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic