This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104337/ |
On March 19th, 2012, 12:17 a.m., Henry Miller wrote:
In kauth/autotests/HelperTest.cpp The comment on line 57-68 should be reworded. In general when someone is told not to touch some lines they won't. You should be clear on why the code is that way. However saying "you don't want to touch this code" is a bad thing. It gives someone permission to not look close, even when in the future their change would break things. Yes what you are doing is subtle, but that is no excuse for someone to not understand it.
Well, the comment was indeed meant to be ironic and funny, and I can indeed rephrase it if it's not desirable. Though, there is all the needed insights into that trick, which is: "Qt's local loop optimizations at the moment make it impossible to stream an async request to a process living on the same thread. So that's what we do: we instantiate a separate helperProxy and move it to a different thread - afterwards we can do everything as if we were in a separate process. If you are wondering if this means we'll have two helper proxies, you are right my friend. But please remember that helperProxy acts both as a client and as a server, so it makes total sense." But I can understand if the remaining part does not look appropriate - it's just that I usually don't like reading boring comments ;)
- Dario
On March 18th, 2012, 10:25 p.m., Dario Freddi wrote:
Review request for kdelibs, Kevin Ottens, David Faure, and Alexander Neundorf.
By Dario Freddi.
Updated March 18, 2012, 10:25 p.m. Description
Testing
Diffs
|