[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Pass decorationSize to QStyleOptionView in KWidgetItemDelegatePrivate
From: "Christoph Feck" <christoph () maxiom ! de>
Date: 2012-03-18 1:59:20
Message-ID: 20120318015920.28379.92025 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104322/#review11514
-----------------------------------------------------------
Hm, having to "patch" this at multiple locations makes me believe there sho=
uld be a helper function, even if inline, that does all the option setup?
- Christoph Feck
On March 18, 2012, 1:44 a.m., Daniele Elmo Domenichelli wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104322/
> -----------------------------------------------------------
> =
> (Updated March 18, 2012, 1:44 a.m.)
> =
> =
> Review request for kdelibs.
> =
> =
> Description
> -------
> =
> Pass decorationSize to QStyleOptionView in KWidgetItemDelegatePrivate
> =
> =
> Diffs
> -----
> =
> kdeui/itemviews/kwidgetitemdelegate.cpp 4378e417af2469bb52896648cce70bc=
523a07a16 =
> =
> Diff: http://git.reviewboard.kde.org/r/104322/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Daniele Elmo Domenichelli
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104322/">http://git.reviewboard.kde.org/r/104322/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm, having to \
"patch" this at multiple locations makes me believe there should be a \
helper function, even if inline, that does all the option setup?</pre> <br />
<p>- Christoph</p>
<br />
<p>On March 18th, 2012, 1:44 a.m., Daniele Elmo Domenichelli wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Daniele Elmo Domenichelli.</div>
<p style="color: grey;"><i>Updated March 18, 2012, 1:44 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Pass decorationSize to QStyleOptionView in \
KWidgetItemDelegatePrivate</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/itemviews/kwidgetitemdelegate.cpp <span style="color: \
grey">(4378e417af2469bb52896648cce70bc523a07a16)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104322/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic