[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request: Fix readLongLink method
From:       "Mario Bensi" <nef () ipsquad ! net>
Date:       2012-02-24 17:22:59
Message-ID: 20120224172259.5647.22349 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104062/
-----------------------------------------------------------

Review request for kdelibs and David Faure.


Description
-------

We need to skip the value also when the skip are equal to 0x200
otherwise the value of the next buffer is dirty, is beginning with the
end of the last buffer and if the skip are equal to 0x200 the first byte
of the next buffer is 0 and if we find 0 at the first place we stop the
process.


Diffs
-----

  kdecore/io/ktar.cpp 9c3a010 =

  kdecore/tests/karchivetest.cpp 6eab645 =


Diff: http://git.reviewboard.kde.org/r/104062/diff/


Testing
-------


Thanks,

Mario Bensi


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104062/">http://git.reviewboard.kde.org/r/104062/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs and David Faure.</div>
<div>By Mario Bensi.</div>







<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">We need to skip the value also when the skip are equal to 0x200 \
otherwise the value of the next buffer is dirty, is beginning with the end of the \
last buffer and if the skip are equal to 0x200 the first byte of the next buffer is 0 \
and if we find 0 at the first place we stop the process.</pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kdecore/io/ktar.cpp <span style="color: grey">(9c3a010)</span></li>

 <li>kdecore/tests/karchivetest.cpp <span style="color: grey">(6eab645)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104062/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic