[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Add recentdocuments:/ kio slave to kde-runtime.
From: "Albert Astals Cid" <tsdgeos () terra ! es>
Date: 2012-02-02 23:27:13
Message-ID: 20120202232713.18099.32517 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103849/#review10300
-----------------------------------------------------------
You need a Messages.sh to extract your i18n calls so that they can be translated
kioslave/recentdocuments/recentdocuments.cpp
<http://git.reviewboard.kde.org/r/103849/#comment8488>
That kdelibs4 does not make sense, you need your own translation catalog, loading \
the kdelibs4 catalog only won't help
kioslave/recentdocuments/recentdocuments.protocol
<http://git.reviewboard.kde.org/r/103849/#comment8487>
Why 4 maxInstances?
- Albert Astals Cid
On Feb. 2, 2012, 3:23 p.m., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103849/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2012, 3:23 p.m.)
>
>
> Review request for KDE Runtime.
>
>
> Description
> -------
>
> Add recentdocuments:/ kio slave to kde-runtime.
> Did some little rename "recentdocument -> recentdocuments", based on \
> http://kde-apps.org/content/show.php?content=145878
>
> Diffs
> -----
>
> kioslave/CMakeLists.txt f3d5b00
> kioslave/recentdocuments/CMakeLists.txt PRE-CREATION
> kioslave/recentdocuments/recentdocuments.h PRE-CREATION
> kioslave/recentdocuments/recentdocuments.cpp PRE-CREATION
> kioslave/recentdocuments/recentdocuments.protocol PRE-CREATION
> kioslave/recentdocuments/recentdocumentsnotifier.h PRE-CREATION
> kioslave/recentdocuments/recentdocumentsnotifier.cpp PRE-CREATION
> kioslave/recentdocuments/recentdocumentsnotifier.desktop PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/103849/diff/diff
>
>
> Testing
> -------
>
> Works for me.
>
>
> Thanks,
>
> Xuetian Weng
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103849/">http://git.reviewboard.kde.org/r/103849/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You need a Messages.sh \
to extract your i18n calls so that they can be translated</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103849/diff/1/?file=48505#file48505line22" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kioslave/recentdocuments/recentdocuments.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">extern "C" int KDE_EXPORT kdemain(int argc, char **argv)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">22</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KComponentData</span><span class="p">(</span><span \
class="s">"kio_recentdocuments"</span><span class="p">,</span> <span \
class="s">"kdelibs4"</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That \
kdelibs4 does not make sense, you need your own translation catalog, loading the \
kdelibs4 catalog only won't help</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103849/diff/1/?file=48506#file48506line13" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kioslave/recentdocuments/recentdocuments.protocol</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">13</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">maxInstances=4</pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why 4 \
maxInstances?</pre> </div>
<br />
<p>- Albert</p>
<br />
<p>On February 2nd, 2012, 3:23 p.m., Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Feb. 2, 2012, 3:23 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add recentdocuments:/ kio slave to kde-runtime. Did some little rename \
"recentdocument -> recentdocuments", based on \
http://kde-apps.org/content/show.php?content=145878</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works for me.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/CMakeLists.txt <span style="color: grey">(f3d5b00)</span></li>
<li>kioslave/recentdocuments/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kioslave/recentdocuments/recentdocuments.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kioslave/recentdocuments/recentdocuments.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kioslave/recentdocuments/recentdocuments.protocol <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kioslave/recentdocuments/recentdocumentsnotifier.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kioslave/recentdocuments/recentdocumentsnotifier.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kioslave/recentdocuments/recentdocumentsnotifier.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103849/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic