[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Port shutdown dialog to QML
From: "Lamarque Vieira Souza" <lamarque () kde ! org>
Date: 2012-01-30 17:47:36
Message-ID: 20120130174736.1127.40838 () vidsolbach ! de
[Download RAW message or body]
> On Jan. 30, 2012, 4:44 p.m., Raphael Kubo da Costa wrote:
> > ksmserver/FindKDeclarative.cmake, line 14
> > <http://git.reviewboard.kde.org/r/103621/diff/8/?file=48390#file48390line14>
> >
> > Where is Copyright.txt? :)
> >
> > If you move this file to cmake/modules you can share the license header with the \
> > other files there and just point to COPYING-CMAKE-SCRIPTS (if you do so, it's \
> > probably better not to install it, btw).
Copyright.txt added. By the way, kdelibs does not include that file for \
FindJPEG.cmake. If I move it to cmake/modules it is installed by default and \
Alexander Neundorf <neundorf@kde.org> already said to do not install it.
> On Jan. 30, 2012, 4:44 p.m., Raphael Kubo da Costa wrote:
> > ksmserver/FindKDeclarative.cmake, line 25
> > <http://git.reviewboard.kde.org/r/103621/diff/8/?file=48390#file48390line25>
> >
> > Can you elaborate on why KDECLARATIVE_LIBRARY is being used/set?
I cannot. I used FindJPEG.cmake as an example as suggested by Alexander Neundorf. I \
do not know why it is used in FindJPEG.cmake and how it works.
- Lamarque Vieira
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103621/#review10238
-----------------------------------------------------------
On Jan. 30, 2012, 5:08 p.m., Lamarque Vieira Souza wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103621/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2012, 5:08 p.m.)
>
>
> Review request for KDE Base Apps and KDE Runtime.
>
>
> Description
> -------
>
> Port shutdown dialog to QML. Two QML themes are included: default, which mimics the \
> current shutdown dialog look & feel, and contour, which is used in Plasma Active.
>
> This addresses bugs 216853 and 216853.
> http://bugs.kde.org/show_bug.cgi?id=216853
> http://bugs.kde.org/show_bug.cgi?id=216853
>
>
> Diffs
> -----
>
> ksmserver/CMakeLists.txt 295b96e
> ksmserver/Copyright.txt PRE-CREATION
> ksmserver/FindKDeclarative.cmake PRE-CREATION
> ksmserver/Messages.sh 0aa8bab
> ksmserver/shutdown.cpp 7fd1e11
> ksmserver/shutdowndlg.h e5f0942
> ksmserver/shutdowndlg.cpp a09a1a7
> ksmserver/themes/contour/ContourButton.qml PRE-CREATION
> ksmserver/themes/contour/main.qml PRE-CREATION
> ksmserver/themes/contour/metadata.desktop PRE-CREATION
> ksmserver/themes/contour/screenshot.png PRE-CREATION
> ksmserver/themes/default/ContextMenu.qml PRE-CREATION
> ksmserver/themes/default/KSMButton.qml PRE-CREATION
> ksmserver/themes/default/MenuItem.qml PRE-CREATION
> ksmserver/themes/default/helper.js PRE-CREATION
> ksmserver/themes/default/main.qml PRE-CREATION
> ksmserver/themes/default/metadata.desktop PRE-CREATION
> ksmserver/themes/default/screenshot.png PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/103621/diff/diff
>
>
> Testing
> -------
>
> Works in Plasma Active Two using MeeGo image and KDE SC 4.8. It does not work in \
> 4.7.x because the default theme requires kde-runtime 4.8's declarative imports.
> TODO:
>
> . test right to left language support.
>
>
> Screenshots
> -----------
>
>
> http://git.reviewboard.kde.org/r/103621/s/400/
> New version with label accelerator working
> http://git.reviewboard.kde.org/r/103621/s/407/
>
>
> Thanks,
>
> Lamarque Vieira Souza
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103621/">http://git.reviewboard.kde.org/r/103621/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 30th, 2012, 4:44 p.m., <b>Raphael Kubo \
da Costa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103621/diff/8/?file=48390#file48390line14" \
style="color: black; font-weight: bold; text-decoration: \
underline;">ksmserver/FindKDeclarative.cmake</a> <span style="font-weight: normal;">
(Diff revision 8)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">14</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="c"># see accompanying file Copyright.txt for details.</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Where is Copyright.txt? \
:)
If you move this file to cmake/modules you can share the license header with the \
other files there and just point to COPYING-CMAKE-SCRIPTS (if you do so, it's \
probably better not to install it, btw).</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Copyright.txt added. By the way, kdelibs does not include that file for \
FindJPEG.cmake. If I move it to cmake/modules it is installed by default and \
Alexander Neundorf <neundorf@kde.org> already said to do not install it.</pre> \
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 30th, 2012, 4:44 p.m., <b>Raphael Kubo \
da Costa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103621/diff/8/?file=48390#file48390line25" \
style="color: black; font-weight: bold; text-decoration: \
underline;">ksmserver/FindKDeclarative.cmake</a> <span style="font-weight: normal;">
(Diff revision 8)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">25</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">FIND_LIBRARY</span><span class="p">(</span><span \
class="s">KDECLARATIVE_LIBRARY</span> <span class="s">NAMES</span> <span \
class="s">kdeclarative</span> <span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you elaborate on why \
KDECLARATIVE_LIBRARY is being used/set?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I cannot. I \
used FindJPEG.cmake as an example as suggested by Alexander Neundorf. I do not know \
why it is used in FindJPEG.cmake and how it works.</pre> <br />
<p>- Lamarque Vieira</p>
<br />
<p>On January 30th, 2012, 5:08 p.m., Lamarque Vieira Souza wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps and KDE Runtime.</div>
<div>By Lamarque Vieira Souza.</div>
<p style="color: grey;"><i>Updated Jan. 30, 2012, 5:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Port shutdown dialog to QML. Two QML themes are included: default, which \
mimics the current shutdown dialog look & feel, and contour, which is used in \
Plasma Active.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works in Plasma Active Two using MeeGo image and KDE SC 4.8. It does not \
work in 4.7.x because the default theme requires kde-runtime 4.8's declarative \
imports.
TODO:
. test right to left language support.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=216853">216853</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=216853">216853</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/CMakeLists.txt <span style="color: grey">(295b96e)</span></li>
<li>ksmserver/Copyright.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/FindKDeclarative.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/Messages.sh <span style="color: grey">(0aa8bab)</span></li>
<li>ksmserver/shutdown.cpp <span style="color: grey">(7fd1e11)</span></li>
<li>ksmserver/shutdowndlg.h <span style="color: grey">(e5f0942)</span></li>
<li>ksmserver/shutdowndlg.cpp <span style="color: grey">(a09a1a7)</span></li>
<li>ksmserver/themes/contour/ContourButton.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/themes/contour/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/themes/contour/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/themes/contour/screenshot.png <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/themes/default/ContextMenu.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/themes/default/KSMButton.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/themes/default/MenuItem.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/themes/default/helper.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/themes/default/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/themes/default/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/themes/default/screenshot.png <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103621/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103621/s/400/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/01/03/qml-shutdowndlg_rebootmenu_400x100.jpeg" \
style="border: 1px black solid;" alt="" /></a>
<a href="http://git.reviewboard.kde.org/r/103621/s/407/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/01/05/qml-shutdowndlg_rebootmenu_label_accelerators_400x100.jpeg" \
style="border: 1px black solid;" alt="New version with label accelerator working" \
/></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic