'Re: Review Request: Port shutdown dialog to QML'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Port shutdown dialog to QML
From:       "Raphael Kubo da Costa" <rakuco () freebsd ! org>
Date:       2012-01-30 15:40:48
Message-ID: 20120130154048.27451.43095 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103621/#review10232
-----------------------------------------------------------


Isn't it better to move FindKDeclarative.cmake to the top-level cmake/modules \
directory with the other find-files?


ksmserver/FindKDeclarative.cmake
<http://git.reviewboard.kde.org/r/103621/#comment8421>

    As picky as it may seem, doesn't this file need a license?



ksmserver/FindKDeclarative.cmake
<http://git.reviewboard.kde.org/r/103621/#comment8422>

    Why is this needed?



ksmserver/FindKDeclarative.cmake
<http://git.reviewboard.kde.org/r/103621/#comment8424>

    Why not pass KDECLARATIVE_LIBRARIES directly to find_library() to get rid of this \
block?



ksmserver/FindKDeclarative.cmake
<http://git.reviewboard.kde.org/r/103621/#comment8423>

    I don't see these being used anywhere in the patch, does it make sense to keep \
deprecated declarations in a new file?



ksmserver/FindKDeclarative.cmake
<http://git.reviewboard.kde.org/r/103621/#comment8425>

    Missing KDECLARATIVE_LIBRARIES?


- Raphael Kubo da Costa


On Jan. 30, 2012, 2:28 p.m., Lamarque Vieira Souza wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103621/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2012, 2:28 p.m.)
> 
> 
> Review request for KDE Base Apps and KDE Runtime.
> 
> 
> Description
> -------
> 
> Port shutdown dialog to QML. Two QML themes are included: default, which mimics the \
> current shutdown dialog look & feel, and contour, which is used in Plasma Active. 
> 
> This addresses bugs 216853 and 216853.
> http://bugs.kde.org/show_bug.cgi?id=216853
> http://bugs.kde.org/show_bug.cgi?id=216853
> 
> 
> Diffs
> -----
> 
> ksmserver/CMakeLists.txt 295b96e 
> ksmserver/FindKDeclarative.cmake PRE-CREATION 
> ksmserver/Messages.sh 0aa8bab 
> ksmserver/shutdown.cpp 7fd1e11 
> ksmserver/shutdowndlg.h e5f0942 
> ksmserver/shutdowndlg.cpp a09a1a7 
> ksmserver/themes/contour/ContourButton.qml PRE-CREATION 
> ksmserver/themes/contour/main.qml PRE-CREATION 
> ksmserver/themes/contour/metadata.desktop PRE-CREATION 
> ksmserver/themes/contour/screenshot.png PRE-CREATION 
> ksmserver/themes/default/ContextMenu.qml PRE-CREATION 
> ksmserver/themes/default/KSMButton.qml PRE-CREATION 
> ksmserver/themes/default/MenuItem.qml PRE-CREATION 
> ksmserver/themes/default/helper.js PRE-CREATION 
> ksmserver/themes/default/main.qml PRE-CREATION 
> ksmserver/themes/default/metadata.desktop PRE-CREATION 
> ksmserver/themes/default/screenshot.png PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103621/diff/diff
> 
> 
> Testing
> -------
> 
> Works in Plasma Active Two using MeeGo image and KDE SC 4.8. It does not work in \
> 4.7.x because the default theme requires kde-runtime 4.8's declarative imports. 
> TODO:
> 
> . check if there are bugs in bugs.kde.org that could be solved by this patch.
> . test right to left language support.
> 
> 
> Screenshots
> -----------
> 
> 
> http://git.reviewboard.kde.org/r/103621/s/400/
> New version with label accelerator working
> http://git.reviewboard.kde.org/r/103621/s/407/
> 
> 
> Thanks,
> 
> Lamarque Vieira Souza
> 
> 


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103621/">http://git.reviewboard.kde.org/r/103621/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Isn&#39;t it better to \
move FindKDeclarative.cmake to the top-level cmake/modules directory with the other \
find-files?</pre>  <br />





<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103621/diff/7/?file=48371#file48371line1" \
style="color: black; font-weight: bold; text-decoration: \
underline;">ksmserver/FindKDeclarative.cmake</a>  <span style="font-weight: normal;">

     (Diff revision 7)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="c"># Copyright 2012 Lamarque V. Souza \
&lt;lamarque@kde.org&gt;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As picky as \
it may seem, doesn&#39;t this file need a license?</pre> </div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103621/diff/7/?file=48371#file48371line14" \
style="color: black; font-weight: bold; text-decoration: \
underline;">ksmserver/FindKDeclarative.cmake</a>  <span style="font-weight: normal;">

     (Diff revision 7)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">14</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">SET</span><span class="p">(</span><span \
class="s">KDECLARATIVE_NAMES</span> <span class="o">${</span><span \
class="nv">KDECLARATIVE_NAMES</span><span class="o">}</span> <span \
class="s">kdeclarative</span><span class="p">)</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why is this \
needed?</pre> </div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103621/diff/7/?file=48371#file48371line22" \
style="color: black; font-weight: bold; text-decoration: \
underline;">ksmserver/FindKDeclarative.cmake</a>  <span style="font-weight: normal;">

     (Diff revision 7)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">22</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">IF</span><span class="p">(</span><span \
class="s">KDECLARATIVE_FOUND</span><span class="p">)</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">23</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">  <span \
class="nb">SET</span><span class="p">(</span><span \
class="s">KDECLARATIVE_LIBRARIES</span> <span class="o">${</span><span \
class="nv">KDECLARATIVE_LIBRARY</span><span class="o">}</span><span \
class="p">)</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">24</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">ENDIF</span><span class="p">(</span><span \
class="s">KDECLARATIVE_FOUND</span><span class="p">)</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why not \
pass KDECLARATIVE_LIBRARIES directly to find_library() to get rid of this \
block?</pre> </div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103621/diff/7/?file=48371#file48371line26" \
style="color: black; font-weight: bold; text-decoration: \
underline;">ksmserver/FindKDeclarative.cmake</a>  <span style="font-weight: normal;">

     (Diff revision 7)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">26</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="c"># Deprecated declarations.</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">27</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">SET</span> <span class="p">(</span><span \
class="s">NATIVE_KDECLARATIVE_INCLUDE_PATH</span> <span class="o">${</span><span \
class="nv">KDECLARATIVE_INCLUDE_DIR</span><span class="o">}</span> <span \
class="p">)</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">28</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">IF</span><span class="p">(</span><span \
class="s">KDECLARATIVE_LIBRARY</span><span class="p">)</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">29</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">  <span \
class="nb">GET_FILENAME_COMPONENT</span> <span class="p">(</span><span \
class="s">NATIVE_KDECLARATIVE_LIB_PATH</span> <span class="o">${</span><span \
class="nv">KDECLARATIVE_LIBRARY</span><span class="o">}</span> <span \
class="s">PATH</span><span class="p">)</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">30</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">ENDIF</span><span class="p">(</span><span \
class="s">KDECLARATIVE_LIBRARY</span><span class="p">)</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don&#39;t \
see these being used anywhere in the patch, does it make sense to keep deprecated \
declarations in a new file?</pre> </div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103621/diff/7/?file=48371#file48371line32" \
style="color: black; font-weight: bold; text-decoration: \
underline;">ksmserver/FindKDeclarative.cmake</a>  <span style="font-weight: normal;">

     (Diff revision 7)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">32</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">MARK_AS_ADVANCED</span><span class="p">(</span><span \
class="s">KDECLARATIVE_LIBRARY</span> <span class="s">KDECLARATIVE_INCLUDE_DIR</span> \
<span class="p">)</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Missing \
KDECLARATIVE_LIBRARIES?</pre> </div>
<br />



<p>- Raphael</p>


<br />
<p>On January 30th, 2012, 2:28 p.m., Lamarque Vieira Souza wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Base Apps and KDE Runtime.</div>
<div>By Lamarque Vieira Souza.</div>


<p style="color: grey;"><i>Updated Jan. 30, 2012, 2:28 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Port shutdown dialog to QML. Two QML themes are included: default, which \
mimics the current shutdown dialog look &amp; feel, and contour, which is used in \
Plasma Active.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works in Plasma Active Two using MeeGo image and KDE SC 4.8. It does not \
work in 4.7.x because the default theme requires kde-runtime 4.8&#39;s declarative \
imports.

TODO:

. check if there are bugs in bugs.kde.org that could be solved by this patch.
. test right to left language support.</pre>
  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=216853">216853</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=216853">216853</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/CMakeLists.txt <span style="color: grey">(295b96e)</span></li>

 <li>ksmserver/FindKDeclarative.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>ksmserver/Messages.sh <span style="color: grey">(0aa8bab)</span></li>

 <li>ksmserver/shutdown.cpp <span style="color: grey">(7fd1e11)</span></li>

 <li>ksmserver/shutdowndlg.h <span style="color: grey">(e5f0942)</span></li>

 <li>ksmserver/shutdowndlg.cpp <span style="color: grey">(a09a1a7)</span></li>

 <li>ksmserver/themes/contour/ContourButton.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>ksmserver/themes/contour/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>ksmserver/themes/contour/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>ksmserver/themes/contour/screenshot.png <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>ksmserver/themes/default/ContextMenu.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>ksmserver/themes/default/KSMButton.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>ksmserver/themes/default/MenuItem.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>ksmserver/themes/default/helper.js <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>ksmserver/themes/default/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>ksmserver/themes/default/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>ksmserver/themes/default/screenshot.png <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103621/diff/" style="margin-left: \
3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/103621/s/400/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/01/03/qml-shutdowndlg_rebootmenu_400x100.jpeg" \
style="border: 1px black solid;" alt="" /></a>

 <a href="http://git.reviewboard.kde.org/r/103621/s/407/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/01/05/qml-shutdowndlg_rebootmenu_label_accelerators_400x100.jpeg" \
style="border: 1px black solid;" alt="New version with label accelerator working" \
/></a>

</div>


  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic