[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Add option to control PAM support
From: "Michael Palimaka" <kde () scribeofthenile ! com>
Date: 2012-01-30 9:47:08
Message-ID: 20120130094708.5103.17188 () vidsolbach ! de
[Download RAW message or body]
> On Jan. 29, 2012, 4:42 p.m., Alexander Neundorf wrote:
> > The change in FindPAM.cmake is wrong.
> > FindPAM.cmake does not care whether WITH_PAM is TRUE or not, when called, it will \
> > search PAM. If WITH_PAM is disabled, FindPAM.cmake will not be executed, and \
> > additionally all PAM_* variables will be set to empty. It should work without the \
> > change in FindPAM.cmake.
That is intended behaviour. It should be possible to compile kcheckpass and KDM \
without PAM support, even if PAM is present on the system.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103818/#review10198
-----------------------------------------------------------
On Jan. 29, 2012, 10:35 a.m., Michael Palimaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103818/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2012, 10:35 a.m.)
>
>
> Review request for KDE Base Apps.
>
>
> Description
> -------
>
> kcheckpass and KDM support being built without PAM, but this selection is currently \
> automagic.
> This patch adds a WITH_PAM option, and makes sure that the patched cmake modules \
> are preferred over the system ones.
>
> Diffs
> -----
>
> ConfigureChecks.cmake fe06d9e
> cmake/modules/FindPAM.cmake 3499836
> cmake/modules/UnixAuth.cmake 904f0cb
>
> Diff: http://git.reviewboard.kde.org/r/103818/diff/diff
>
>
> Testing
> -------
>
> For me, both kcheckpass and KDM link against libcrypt instead of PAM and work fine \
> when -DWITH_PAM=no is specified.
>
> Thanks,
>
> Michael Palimaka
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103818/">http://git.reviewboard.kde.org/r/103818/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 29th, 2012, 4:42 p.m., <b>Alexander \
Neundorf</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The change in FindPAM.cmake is wrong. FindPAM.cmake does not care \
whether WITH_PAM is TRUE or not, when called, it will search PAM. If WITH_PAM is \
disabled, FindPAM.cmake will not be executed, and additionally all PAM_* variables \
will be set to empty. It should work without the change in FindPAM.cmake.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That is intended \
behaviour. It should be possible to compile kcheckpass and KDM without PAM support, \
even if PAM is present on the system.</pre> <br />
<p>- Michael</p>
<br />
<p>On January 29th, 2012, 10:35 a.m., Michael Palimaka wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Michael Palimaka.</div>
<p style="color: grey;"><i>Updated Jan. 29, 2012, 10:35 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kcheckpass and KDM support being built without PAM, but this selection \
is currently automagic.
This patch adds a WITH_PAM option, and makes sure that the patched cmake modules are \
preferred over the system ones.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">For me, both kcheckpass and KDM link against libcrypt instead of PAM and \
work fine when -DWITH_PAM=no is specified.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ConfigureChecks.cmake <span style="color: grey">(fe06d9e)</span></li>
<li>cmake/modules/FindPAM.cmake <span style="color: grey">(3499836)</span></li>
<li>cmake/modules/UnixAuth.cmake <span style="color: grey">(904f0cb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103818/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic