[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: Fix capacity text in places panel (and possibly unwanted spin-up behavior)
From: "Peter Penz" <peter.penz19 () gmail ! com>
Date: 2012-01-12 16:55:43
Message-ID: 20120112165543.26223.76185 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103682/#review9772
-----------------------------------------------------------
I'm not the maintainer of the code, but the patch looks good. Definitely a "go" from \
a Dolphin point of view to get this in before 4.8.0 got tagged. Thanks a lot for this \
patch - I stumbled above those issues myself already but did not have the time yet to \
check KFilePlacesView...
- Peter Penz
On Jan. 12, 2012, 4:42 p.m., Christoph Feck wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103682/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2012, 4:42 p.m.)
>
>
> Review request for Dolphin, kdelibs and Solid.
>
>
> Description
> -------
>
> I only tried to fix the double/blurry text (bug 248062), but stumbled upon a \
> possible reason for the unwanted spin-up behavior reported in the other bugs. \
> According to the code, the KFreeDiskSpaceInfo object is queried even if we do not \
> display the capacity bar.
> The attached patch should fix it:
> - the text is not faded at two positions, but moved between those two positions
> - the KFreeDiskSpaceInfo object is only created if we indeed want to show the \
> capacity bar
> I tried to separate the patches for those two issues, but it was not possible.
>
> Please review.
>
>
> This addresses bugs 184449, 248062, 261552, 264487, and 268103.
> http://bugs.kde.org/show_bug.cgi?id=184449
> http://bugs.kde.org/show_bug.cgi?id=248062
> http://bugs.kde.org/show_bug.cgi?id=261552
> http://bugs.kde.org/show_bug.cgi?id=264487
> http://bugs.kde.org/show_bug.cgi?id=268103
>
>
> Diffs
> -----
>
> kfile/kfileplacesview.cpp 6a343b3
>
> Diff: http://git.reviewboard.kde.org/r/103682/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christoph Feck
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103682/">http://git.reviewboard.kde.org/r/103682/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not the \
maintainer of the code, but the patch looks good. Definitely a "go" from a \
Dolphin point of view to get this in before 4.8.0 got tagged. Thanks a lot for this \
patch - I stumbled above those issues myself already but did not have the time yet to \
check KFilePlacesView...</pre> <br />
<p>- Peter</p>
<br />
<p>On January 12th, 2012, 4:42 p.m., Christoph Feck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin, kdelibs and Solid.</div>
<div>By Christoph Feck.</div>
<p style="color: grey;"><i>Updated Jan. 12, 2012, 4:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I only tried to fix the double/blurry text (bug 248062), but stumbled \
upon a possible reason for the unwanted spin-up behavior reported in the other bugs. \
According to the code, the KFreeDiskSpaceInfo object is queried even if we do not \
display the capacity bar.
The attached patch should fix it:
- the text is not faded at two positions, but moved between those two positions
- the KFreeDiskSpaceInfo object is only created if we indeed want to show the \
capacity bar
I tried to separate the patches for those two issues, but it was not possible.
Please review.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=184449">184449</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=248062">248062</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=261552">261552</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=264487">264487</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=268103">268103</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kfile/kfileplacesview.cpp <span style="color: grey">(6a343b3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103682/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic