[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Make KGlobalSettings reread locale settings
From: "Lamarque V. Souza" <lamarque () kde ! org>
Date: 2011-12-19 17:01:51
Message-ID: 201112191501.51815.lamarque () kde ! org
[Download RAW message or body]
Em Monday 19 December 2011, David Faure escreveu:
> On Monday 19 December 2011 15:46:14 Lamarque Vieira Souza wrote:
> > > On Dec. 19, 2011, 2:35 p.m., David Faure wrote:
> > > > kdeui/kernel/kglobalsettings.cpp, line 886
> > > > <http://git.reviewboard.kde.org/r/103469/diff/2/?file=43867#file43867
> > > > lin e886>> >
> > > >
> > > > I like the idea (KGlobalSettings reparsing configuration), but
> > > > not the implementation (setLanguage(langage)). Can't KLocale get
> > > > a reparseConfiguration() (to reuse the KConfig naming) ?
> >
> > KLocale::reparseConfiguration() would be just a call to
> > KLocalePrivate::initFormat(), but initFormat is protected. I will have to
> > make it public to use it in KLocale::reparseConfiguration, wouldn't that
> > break binary compatibility?
>
> Aeh? If it's called KLocalePrivate it's a private class, you can do
> whatever you want with it.
Well, it's called KLocalePrivate but it has a lot of protected methods
that KLocale cannot access, initFormat is one of them:
../../kdecore/localization/klocale_p.h: In member function 'void
KLocale::reparseConfiguration()':
../../kdecore/localization/klocale_p.h:81:18: error: 'virtual void
KLocalePrivate::initFormat()' is protected
../../kdecore/localization/klocale.cpp:786:19: error: within this context
--
Lamarque V. Souza
KDE's Network Management maintainer
http://planetkde.org/pt-br
[Attachment #3 (text/html)]
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" \
"http://www.w3.org/TR/REC-html40/strict.dtd"> <html><head><meta name="qrichtext" \
content="1" /><style type="text/css"> p, li { white-space: pre-wrap; }
</style></head><body style=" font-family:'Tahoma'; font-size:12pt; font-weight:400; \
font-style:normal;"> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Em Monday \
19 December 2011, David Faure escreveu:</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">> On Monday 19 December 2011 15:46:14 Lamarque \
Vieira Souza wrote:</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">> > > On Dec. 19, 2011, 2:35 p.m., David Faure wrote:</p> \
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> > > > \
kdeui/kernel/kglobalsettings.cpp, line 886</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">> > > > \
<http://git.reviewboard.kde.org/r/103469/diff/2/?file=43867#file43867</p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> > > > lin \
e886>> ></p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> > \
> > </p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> > \
> > I like the idea (KGlobalSettings reparsing configuration), but</p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> > > > not \
the implementation (setLanguage(langage)). Can't KLocale get</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> > > > a \
reparseConfiguration() (to reuse the KConfig naming) ?</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">> > </p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">> > KLocale::reparseConfiguration() would \
be just a call to</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> > \
KLocalePrivate::initFormat(), but initFormat is protected. I will have to</p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> > make it public to \
use it in KLocale::reparseConfiguration, wouldn't that</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">> > break binary compatibility?</p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> </p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">> Aeh? If it's called \
KLocalePrivate it's a private class, you can do</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">> whatever you want with it.</p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; "> </p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;"> Well, it's called \
KLocalePrivate but it has a lot of protected methods that KLocale cannot access, \
initFormat is one of them:</p> <p style="-qt-paragraph-type:empty; margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; "> </p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">../../kdecore/localization/klocale_p.h: In member function 'void \
KLocale::reparseConfiguration()':</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">../../kdecore/localization/klocale_p.h:81:18: error: 'virtual void \
KLocalePrivate::initFormat()' is protected</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">../../kdecore/localization/klocale.cpp:786:19: \
error: within this context</p> <p style="-qt-paragraph-type:empty; margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; "> </p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">-- </p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">Lamarque V. Souza</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;">KDE's Network Management maintainer</p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">http://planetkde.org/pt-br</p></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic