[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: fix infinite recurssion in kcategorizedview
From: "Jaime Torres Amate" <jtamate () gmail ! com>
Date: 2011-12-05 8:07:23
Message-ID: 20111205080723.2826.62291 () vidsolbach ! de
[Download RAW message or body]
> On Dec. 4, 2011, 6:47 p.m., Thomas Lübking wrote:
> > Ok, i think i know what's wrong.
> > KCategorizedView::updateGeometries() calls QListView::updateGeometries() which has it's own \
> > opinion on whether the scrollbars should be visible (valid range) or not and triggers a \
> > (sometimes additionally timered) resize through ::layoutChildren() \
> > http://qt.gitorious.org/qt/qt/blobs/4.7/src/gui/itemviews/qlistview.cpp#line1499 - the \
> > comment above the main block isn't all accurate, layoutChldren is called regardless of the \
> > policy.
> > My approach was then to prevent QListView from having an own opinion on the scrollbar \
> > visibility by fixing it before calling the baseclass QListView::updateGeometries()
> >
> > // bug 213068 ------------------------------------------------------------
> > const Qt::ScrollBarPolicy verticalP = verticalScrollBarPolicy(), horizontalP = \
> > horizontalScrollBarPolicy(); \
> > setVerticalScrollBarPolicy(verticalScrollBar()->isVisibleTo(this) ? Qt::ScrollBarAlwaysOn : \
> > Qt::ScrollBarAlwaysOff); \
> > setHorizontalScrollBarPolicy(horizontalScrollBar()->isVisibleTo(this) ? \
> > Qt::ScrollBarAlwaysOn : Qt::ScrollBarAlwaysOff); // /bug 213068 \
> > ------------------------------------------------------------
> > QListView::updateGeometries();
> >
> > // bug 213068 ------------------------------------------------------------
> > setVerticalScrollBarPolicy(verticalP);
> > setHorizontalScrollBarPolicy(horizontalP);
> > // /bug 213068 ------------------------------------------------------------
> >
> > in addition i ensure the horizontal range was also set on the early skip
> >
> > const int rowCount = d->proxyModel->rowCount();
> > if (!rowCount) {
> > horizontalScrollBar()->setRange(0, 0);
> > verticalScrollBar()->setRange(0, 0);
> > return;
> > }
> >
> > but i actually doubt this is relevant.
> >
> > However, i cannot reproduce the issue (commenting the fixed policies in \
> > kpluginselector.cpp) and as a bonus kpluginselector resizes faster (resize/geometryUpdate \
> > came in pairs here before, not tested with the patch but it feels faster ;-)
> > Can please anyone attempt to confirm or deny the approach?
If your patch includes your comment, you have my Ship it!.
- Jaime Torres
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103313/#review8704
-----------------------------------------------------------
On Dec. 4, 2011, 8:42 a.m., Jaime Torres Amate wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103313/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2011, 8:42 a.m.)
>
>
> Review request for kdelibs and Rafael Fernández López.
>
>
> Description
> -------
>
> Basically, what I do is:
> If there are one or zero columns, hide the horizontalScrollBar until it is needed. (it has \
> worked in the past, but in another file). Apply the same strategy with files.
>
> Additional stuff:
> Moved the common calculus of itemSize outside of the if then else.
>
>
> This addresses bugs 213068 and 287847.
> http://bugs.kde.org/show_bug.cgi?id=213068
> http://bugs.kde.org/show_bug.cgi?id=287847
>
>
> Diffs
> -----
>
> kdeui/itemviews/kcategorizedview.cpp 46a1cde
> kutils/kpluginselector.cpp ca0691d
>
> Diff: http://git.reviewboard.kde.org/r/103313/diff/diff
>
>
> Testing
> -------
>
> Krunner config does not loop (neither kgetnewstuff from kstars). I can not test with amarok \
> (I've hit by an amarok start bug). Please, test with other programs.
>
>
> Thanks,
>
> Jaime Torres Amate
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103313/">http://git.reviewboard.kde.org/r/103313/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 4th, 2011, 6:47 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Ok, i think i know what's wrong. \
KCategorizedView::updateGeometries() calls QListView::updateGeometries() which has it's own \
opinion on whether the scrollbars should be visible (valid range) or not and triggers a \
(sometimes additionally timered) resize through ::layoutChildren() \
http://qt.gitorious.org/qt/qt/blobs/4.7/src/gui/itemviews/qlistview.cpp#line1499 - the comment \
above the main block isn't all accurate, layoutChldren is called regardless of the policy.
My approach was then to prevent QListView from having an own opinion on the scrollbar \
visibility by fixing it before calling the baseclass QListView::updateGeometries()
// bug 213068 ------------------------------------------------------------
const Qt::ScrollBarPolicy verticalP = verticalScrollBarPolicy(), horizontalP = \
horizontalScrollBarPolicy(); \
setVerticalScrollBarPolicy(verticalScrollBar()->isVisibleTo(this) ? Qt::ScrollBarAlwaysOn : \
Qt::ScrollBarAlwaysOff); \
setHorizontalScrollBarPolicy(horizontalScrollBar()->isVisibleTo(this) ? \
Qt::ScrollBarAlwaysOn : Qt::ScrollBarAlwaysOff); // /bug 213068 \
------------------------------------------------------------
QListView::updateGeometries();
// bug 213068 ------------------------------------------------------------
setVerticalScrollBarPolicy(verticalP);
setHorizontalScrollBarPolicy(horizontalP);
// /bug 213068 ------------------------------------------------------------
in addition i ensure the horizontal range was also set on the early skip
const int rowCount = d->proxyModel->rowCount();
if (!rowCount) {
horizontalScrollBar()->setRange(0, 0);
verticalScrollBar()->setRange(0, 0);
return;
}
but i actually doubt this is relevant.
However, i cannot reproduce the issue (commenting the fixed policies in kpluginselector.cpp) \
and as a bonus kpluginselector resizes faster (resize/geometryUpdate came in pairs here before, \
not tested with the patch but it feels faster ;-)
Can please anyone attempt to confirm or deny the approach?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">If your patch includes your comment, you have \
my Ship it!.</pre> <br />
<p>- Jaime Torres</p>
<br />
<p>On December 4th, 2011, 8:42 a.m., Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kdelibs and Rafael Fernández López.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Dec. 4, 2011, 8:42 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Basically, what I do \
is: If there are one or zero columns, hide the horizontalScrollBar until it is needed. (it has \
worked in the past, but in another file). Apply the same strategy with files.
Additional stuff:
Moved the common calculus of itemSize outside of the if then else.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Krunner config does \
not loop (neither kgetnewstuff from kstars). I can not test with amarok (I've hit by an \
amarok start bug). Please, test with other programs.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=213068">213068</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=287847">287847</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/itemviews/kcategorizedview.cpp <span style="color: grey">(46a1cde)</span></li>
<li>kutils/kpluginselector.cpp <span style="color: grey">(ca0691d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103313/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic