This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103313/

kdeui/itemviews/kcategorizedview.cpp (Diff revision 2) 
void KCategorizedView::rowsAboutToBeRemoved(const QModelIndex &parent,
 

    1376
    
        return;

  


 





I would say 'no halfway exit always' especially in long functions. Midfunc exit is too easily overlooked. That said, if most of processing is done in else loop if you elide the midfunc exit then the function is even more a refactoring candidate. If readability suffers... yet another reason for refactoring. 









- Ruurd






On December 4th, 2011, 8:42 a.m., Jaime Torres Amate wrote:









 

  


Review request for kdelibs and Rafael Fernández López.


By Jaime Torres Amate.




Updated Dec. 4, 2011, 8:42 a.m.








Description 

 

 

  
   
Basically, what I do is:
If there are one or zero columns, hide the horizontalScrollBar until it is needed. (it has worked in the past, but in another file).
Apply the same strategy with files.

Additional stuff:
Moved the common calculus of itemSize outside of the if then else.

  		
 






Testing 



 

  
   
Krunner config does not loop (neither kgetnewstuff from kstars). I can not test with amarok (I've hit by an amarok start bug).
Please, test with other programs.

  		
 








 Bugs: 


 213068, 

 287847







Diffs 


    

 
  • kdeui/itemviews/kcategorizedview.cpp (46a1cde)
    • 

 
  • kutils/kpluginselector.cpp (ca0691d)
    • 





View Diff