From kde-core-devel Sun Dec 04 11:29:36 2011 From: "Commit Hook" Date: Sun, 04 Dec 2011 11:29:36 +0000 To: kde-core-devel Subject: Re: Review Request: three trivial fixes and one not so trivial Message-Id: <20111204112936.9300.95378 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=132299829206973 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3709335927592905892==" --===============3709335927592905892== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103323/#review8694 ----------------------------------------------------------- This review has been submitted with commit 2ca961213a86c58b113b1d955000fcb9= 3b96625d by Jaime Torres to branch KDE/4.7. - Commit Hook On Dec. 4, 2011, 10:17 a.m., Jaime Torres Amate wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103323/ > ----------------------------------------------------------- > = > (Updated Dec. 4, 2011, 10:17 a.m.) > = > = > Review request for kdelibs and Aaron J. Seigo. > = > = > Description > ------- > = > In QString AssociatedApplicationManager::application it was returning a v= alue and then trying to connect a signal. > If my change is wrong, there are two possible things to do: > * write a comment to explain the dead code > * remove the dead code > = > = > Diffs > ----- > = > plasma/widgets/signalplotter.cpp aa132dd = > plasma/popupapplet.cpp c363503 = > plasma/private/associatedapplicationmanager.cpp cf8bbe5 = > plasma/private/style.cpp e3449f5 = > = > Diff: http://git.reviewboard.kde.org/r/103323/diff/diff > = > = > Testing > ------- > = > = > Thanks, > = > Jaime Torres Amate > = > --===============3709335927592905892== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103323/

This revie=
w has been submitted with commit 2ca961213a86c58b113b1d955000fcb93b96625d b=
y Jaime Torres to branch KDE/4.7.

- Commit

On December 4th, 2011, 10:17 a.m., Jaime Torres Amate wrote:

Review request for kdelibs and Aaron J. Seigo.

By Jaime Torres Amate.

Updated Dec. 4, 2011, 10:17 a.m.

Descripti= on

In QString AssociatedApplicationManager::application it was =
returning a value and then trying to connect a signal.
If my change is wrong, there are two possible things to do:
* write a comment to explain the dead code
* remove the dead code

Diffs=

plasma/widgets/signalplotter.cpp (aa132dd)=
plasma/popupapplet.cpp (c363503)
plasma/private/associatedapplicationmanager.cpp (cf8bbe5)
plasma/private/style.cpp (e3449f5)<= /li>

View Diff

--===============3709335927592905892==--