[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: three trivial fixes and one not so trivial
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-12-04 11:18:07
Message-ID: 20111204111807.7645.12714 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103323/#review8693
-----------------------------------------------------------
Ship it!
the associatedapplicationmanager.cpp change is incorrect, but easily fixed.=
please address that and then commit. each file change should happen in a c=
ommit of its own.
plasma/private/associatedapplicationmanager.cpp
<http://git.reviewboard.kde.org/r/103323/#comment7322>
these lines should be removed; the connection happens in setApplication=
, and not here.
- Aaron J. Seigo
On Dec. 4, 2011, 10:17 a.m., Jaime Torres Amate wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103323/
> -----------------------------------------------------------
> =
> (Updated Dec. 4, 2011, 10:17 a.m.)
> =
> =
> Review request for kdelibs and Aaron J. Seigo.
> =
> =
> Description
> -------
> =
> In QString AssociatedApplicationManager::application it was returning a v=
alue and then trying to connect a signal.
> If my change is wrong, there are two possible things to do:
> * write a comment to explain the dead code
> * remove the dead code
> =
> =
> Diffs
> -----
> =
> plasma/widgets/signalplotter.cpp aa132dd =
> plasma/popupapplet.cpp c363503 =
> plasma/private/associatedapplicationmanager.cpp cf8bbe5 =
> plasma/private/style.cpp e3449f5 =
> =
> Diff: http://git.reviewboard.kde.org/r/103323/diff/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Jaime Torres Amate
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103323/">http://git.reviewboard.kde.org/r/103323/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">the associatedapplicationmanager.cpp change \
is incorrect, but easily fixed. please address that and then commit. each file change should \
happen in a commit of its own.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; \
padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103323/diff/1/?file=42708#file42708line103" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/private/associatedapplicationmanager.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
AssociatedApplicationManager::setApplication(Plasma::Applet *applet, const QString \
&application)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">103</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span \
class="o">!</span><span class="n">d</span><span class="o">-></span><span \
class="n">applicationNames</span><span class="p">.</span><span class="n">contains</span><span \
class="p">(</span><span class="n">applet</span><span class="p">))</span> <span \
class="p">{</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; \
border-right: 1px solid #C0C0C0;" align="right"><font size="2">102</font></th> <td \
bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="o">!</span><span \
class="n">d</span><span class="o">-></span><span class="n">applicationNames</span><span \
class="p">.</span><span class="n">contains</span><span class="p">(</span><span \
class="n">applet</span><span class="p">))</span> <span class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">104</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; "> <span class="n">connect</span><span \
class="p">(</span><span class="n">applet</span><span class="p">,</span> <span \
class="n">SIGNAL</span><span class="p">(</span><span class="n">destroyed</span><span \
class="p">(</span><span class="n">QObject</span> <span class="o">*</span><span \
class="p">)),</span> <span class="k">this</span><span class="p">,</span> <span \
class="n">SLOT</span><span class="p">(</span><span class="n">cleanupApplet</span><span \
class="p">(</span><span class="n">QObject</span> <span class="o">*</span><span \
class="p">)));</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; \
border-right: 1px solid #C0C0C0;" align="right"><font size="2">103</font></th> <td \
bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">connect</span><span class="p">(</span><span class="n">applet</span><span \
class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span \
class="n">destroyed</span><span class="p">(</span><span class="n">QObject</span> <span \
class="o">*</span><span class="p">)),</span> <span class="k">this</span><span \
class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span \
class="n">cleanupApplet</span><span class="p">(</span><span class="n">QObject</span> <span \
class="o">*</span><span class="p">)));</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">105</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; "> <span class="p">}</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">104</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">these lines should be removed; the \
connection happens in setApplication, and not here.</pre> </div>
<br />
<p>- Aaron J.</p>
<br />
<p>On December 4th, 2011, 10:17 a.m., Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kdelibs and Aaron J. Seigo.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Dec. 4, 2011, 10:17 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In QString \
AssociatedApplicationManager::application it was returning a value and then trying to connect a \
signal. If my change is wrong, there are two possible things to do:
* write a comment to explain the dead code
* remove the dead code
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/widgets/signalplotter.cpp <span style="color: grey">(aa132dd)</span></li>
<li>plasma/popupapplet.cpp <span style="color: grey">(c363503)</span></li>
<li>plasma/private/associatedapplicationmanager.cpp <span style="color: \
grey">(cf8bbe5)</span></li>
<li>plasma/private/style.cpp <span style="color: grey">(e3449f5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103323/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic