[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request: three trivial fixes and one not so trivial
From:       "Jaime Torres Amate" <jtamate () gmail ! com>
Date:       2011-12-04 10:17:08
Message-ID: 20111204101708.5001.35939 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103323/
-----------------------------------------------------------

Review request for kdelibs and Aaron J. Seigo.


Description
-------

In QString AssociatedApplicationManager::application it was returning a val=
ue and then trying to connect a signal.
If my change is wrong, there are two possible things to do:
* write a comment to explain the dead code
* remove the dead code


Diffs
-----

  plasma/widgets/signalplotter.cpp aa132dd =

  plasma/popupapplet.cpp c363503 =

  plasma/private/associatedapplicationmanager.cpp cf8bbe5 =

  plasma/private/style.cpp e3449f5 =


Diff: http://git.reviewboard.kde.org/r/103323/diff/diff


Testing
-------


Thanks,

Jaime Torres Amate


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103323/">http://git.reviewboard.kde.org/r/103323/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs and Aaron J. Seigo.</div>
<div>By Jaime Torres Amate.</div>







<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In QString AssociatedApplicationManager::application it was returning a \
value and then trying to connect a signal. If my change is wrong, there are two \
                possible things to do:
* write a comment to explain the dead code
* remove the dead code
</pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/widgets/signalplotter.cpp <span style="color: grey">(aa132dd)</span></li>

 <li>plasma/popupapplet.cpp <span style="color: grey">(c363503)</span></li>

 <li>plasma/private/associatedapplicationmanager.cpp <span style="color: \
grey">(cf8bbe5)</span></li>

 <li>plasma/private/style.cpp <span style="color: grey">(e3449f5)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103323/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic