This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103313/

Ship it!

if this does indeed fix the problem, then let's ship it as this is a serious issue people run into regularly. i wish there was a better fix than just disabling the horizontal scrollbar, but i'd rather see this not hit users than wait for the "perfect" solution that so far has not been forthcoming.

- Aaron J.


On December 3rd, 2011, 10:55 a.m., Jaime Torres Amate wrote:

Review request for kdelibs.
By Jaime Torres Amate.

Updated Dec. 3, 2011, 10:55 a.m.

Description 

Basically, what I do is:
If there are one or zero columns, hide the horizontalScrollBar until it is needed. (it has worked in the past, but in another file).
Apply the same strategy with files.

Additional stuff:
Moved the common calculus of itemSize outside of the if then else.

Testing 

Krunner config does not loop (neither kgetnewstuff from kstars). I can not test with amarok (I've hit by an amarok start bug).
Please, test with other programs.
Bugs: 213068, 287847

Diffs

  • kdeui/itemviews/kcategorizedview.cpp (46a1cde)
  • kutils/kpluginselector.cpp (ca0691d)

View Diff