[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Fix compilation error in nepomuk kioslave
From: Romário_Rios <luizromario () gmail ! com>
Date: 2011-12-03 11:06:29
Message-ID: 20111203110629.13464.32884 () vidsolbach ! de
[Download RAW message or body]
> On Dec. 3, 2011, 9:27 a.m., Sebastian Trueg wrote:
> > nepomuk/kioslaves/search/kdedmodule/searchurllistener.cpp, line 30
> > <http://git.reviewboard.kde.org/r/103312/diff/1/?file=42633#file42633line30>
> >
> > This does not make any sense. <Nepomuk/Resource> simply includes <nepomuk/resource.h>.
> > Could it be that you tried compiling nepomuk-core?
Yeah, that was that.
Discarding request.
- Romário
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103312/#review8675
-----------------------------------------------------------
On Dec. 3, 2011, 4:42 a.m., Romário Rios wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103312/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2011, 4:42 a.m.)
>
>
> Review request for KDE Runtime.
>
>
> Description
> -------
>
> This patch fixes a compilation error on line 103 of file \
> nepomuk/kioslaves/search/kdedmodule/searchurllistener.cpp (class Nepomuk::Resource has no \
> member named resourceUri).
>
> Diffs
> -----
>
> nepomuk/kioslaves/search/kdedmodule/searchurllistener.cpp 2333e38
>
> Diff: http://git.reviewboard.kde.org/r/103312/diff/diff
>
>
> Testing
> -------
>
> Now it compiles normally here and I don't see how this one-line could go wrong.
>
>
> Thanks,
>
> Romário Rios
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103312/">http://git.reviewboard.kde.org/r/103312/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 3rd, 2011, 9:27 a.m., <b>Sebastian Trueg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; \
padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103312/diff/1/?file=42633#file42633line30" style="color: \
black; font-weight: bold; text-decoration: \
underline;">nepomuk/kioslaves/search/kdedmodule/searchurllistener.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">30</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; "><span class="cp">#include <<span \
class="hl">n</span>epomuk/<span class="hl">r</span>esource<span \
class="hl">.h</span>></span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">30</font></th> <td \
bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#include <<span class="hl">N</span>epomuk/<span \
class="hl">R</span>esource></span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">This does not make any sense. \
<Nepomuk/Resource> simply includes <nepomuk/resource.h>. Could it be that you tried \
compiling nepomuk-core?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah, that was that.
Discarding request.</pre>
<br />
<p>- Romário</p>
<br />
<p>On December 3rd, 2011, 4:42 a.m., Romário Rios wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for KDE Runtime.</div>
<div>By Romário Rios.</div>
<p style="color: grey;"><i>Updated Dec. 3, 2011, 4:42 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch fixes a \
compilation error on line 103 of file nepomuk/kioslaves/search/kdedmodule/searchurllistener.cpp \
(class Nepomuk::Resource has no member named resourceUri).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now it compiles \
normally here and I don't see how this one-line could go wrong.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>nepomuk/kioslaves/search/kdedmodule/searchurllistener.cpp <span style="color: \
grey">(2333e38)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103312/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic