--===============5685258181905886055== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103202/#review8384 ----------------------------------------------------------- plasma/private/containment_p.h ibeg your pardon? to me this looks like you delete the same entry forever (what *will* cr= ash at a point) since you don't remove it - should be "takeFirst", yesno? - Thomas L=C3=BCbking On Nov. 22, 2011, 7:39 a.m., Ben Cooksley wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103202/ > ----------------------------------------------------------- > = > (Updated Nov. 22, 2011, 7:39 a.m.) > = > = > Review request for kdelibs and Plasma. > = > = > Description > ------- > = > Qt 4.8 contains changes which break qDeleteAll() in certain scenarios. Th= is patch fixes one of those scenarios to ensure that Plasma Desktop does no= t crash on quit or logout. > = > = > Diffs > ----- > = > plasma/private/containment_p.h 4025bf4 = > = > Diff: http://git.reviewboard.kde.org/r/103202/diff/diff > = > = > Testing > ------- > = > Compiled, Plasma Desktop no longer crashes on exit. > = > = > Thanks, > = > Ben Cooksley > = > --===============5685258181905886055== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103202/

= =

plasma/private/containment_p.h (Diff revision 1)
public:
		71	while (!applets.isEmpty()) {

ibeg your pardon?
to me this looks like you delete the same entry forever (what *will* crash =
at a point) since you don't remove it - should be "takeFirst"=
, yesno?

- Thomas

On November 22nd, 2011, 7:39 a.m., Ben Cooksley wrote:

Review request for kdelibs and Plasma.

By Ben Cooksley.

Updated Nov. 22, 2011, 7:39 a.m.

Descripti= on

Qt 4.8 contains changes which break qDeleteAll() in certain =
scenarios. This patch fixes one of those scenarios to ensure that Plasma De=
sktop does not crash on quit or logout.

Testing <= /h1>

Compiled, Plasma Desktop no longer crashes on exit.

Diffs=

plasma/private/containment_p.h (4025bf4)

--===============5685258181905886055==--