From kde-core-devel Tue Nov 22 08:13:16 2011 From: "Aaron J. Seigo" Date: Tue, 22 Nov 2011 08:13:16 +0000 To: kde-core-devel Subject: Re: Review Request: Ensure Plasma Desktop does not crash on exit with Message-Id: <20111122081316.31038.32147 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=132194969421254 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7934983901399626957==" --===============7934983901399626957== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103202/#review8378 ----------------------------------------------------------- Ship it! this is massively bad on the part of qt :/ what a crazy, crazy regression. = in any case, yes, this can go in, and the commit should mark BUG:284989 - Aaron J. Seigo On Nov. 22, 2011, 7:39 a.m., Ben Cooksley wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103202/ > ----------------------------------------------------------- > = > (Updated Nov. 22, 2011, 7:39 a.m.) > = > = > Review request for kdelibs and Plasma. > = > = > Description > ------- > = > Qt 4.8 contains changes which break qDeleteAll() in certain scenarios. Th= is patch fixes one of those scenarios to ensure that Plasma Desktop does no= t crash on quit or logout. > = > = > Diffs > ----- > = > plasma/private/containment_p.h 4025bf4 = > = > Diff: http://git.reviewboard.kde.org/r/103202/diff/diff > = > = > Testing > ------- > = > Compiled, Plasma Desktop no longer crashes on exit. > = > = > Thanks, > = > Ben Cooksley > = > --===============7934983901399626957== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103202/

Ship it!

this is ma=
ssively bad on the part of qt :/ what a crazy, crazy regression. in any cas=
e, yes, this can go in, and the commit should mark BUG:284989

- Aaron J.

On November 22nd, 2011, 7:39 a.m., Ben Cooksley wrote:

Review request for kdelibs and Plasma.

By Ben Cooksley.

Updated Nov. 22, 2011, 7:39 a.m.

Descripti= on

Qt 4.8 contains changes which break qDeleteAll() in certain =
scenarios. This patch fixes one of those scenarios to ensure that Plasma De=
sktop does not crash on quit or logout.

Testing <= /h1>

Compiled, Plasma Desktop no longer crashes on exit.

Diffs=

plasma/private/containment_p.h (4025bf4)

View Diff

--===============7934983901399626957==--