From kde-core-devel Thu Nov 10 16:59:44 2011 From: "Commit Hook" Date: Thu, 10 Nov 2011 16:59:44 +0000 To: kde-core-devel Subject: Re: Review Request: Add direct support for remote URLs to previewjob Message-Id: <20111110165944.17987.4763 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=132094447229054 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7680838567537789913==" --===============7680838567537789913== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102929/#review8109 ----------------------------------------------------------- This review has been submitted with commit 6b6af2d3889ecd53ce1aa1a00b1befcb= c244610c by Sebastian K=C3=BCgler to branch KDE/4.7. - Commit Hook On Oct. 22, 2011, 12:55 a.m., Sebastian K=C3=BCgler wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102929/ > ----------------------------------------------------------- > = > (Updated Oct. 22, 2011, 12:55 a.m.) > = > = > Review request for kdelibs. > = > = > Description > ------- > = > This patch allows previewjobs to take a URL in case they understand how t= o deal with that. preview plugis can specify a list of protocols which they= support, this is then matched with the scheme of the URL and if supported = the URL is passed directly into the plugin. Otherwise, the file is download= ed and passed as local file (this part hasn't changed). > = > A suitable preview plugin that does the job will be submitted separately = to kde-runtime. > = > Is this definitively Frameworks 5 material, or would you be OK with addin= g it to the 4.7 branch? (The latter would mean, we could use vanilla kdelib= s for Plasma Active 2 in december.) > = > = > Diffs > ----- > = > kdecore/services/kservice.h 040507c = > kio/kio/previewjob.cpp ff6d340 = > = > Diff: http://git.reviewboard.kde.org/r/102929/diff/diff > = > = > Testing > ------- > = > Generating preview for HTTP URLs, for local files and for remote files wi= thout a suitable plugin. > = > = > Thanks, > = > Sebastian K=C3=BCgler > = > --===============7680838567537789913== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102929/

This revie=
w has been submitted with commit 6b6af2d3889ecd53ce1aa1a00b1befcbc244610c b=
y Sebastian K=C3=BCgler to branch KDE/4.7.

- Commit

On October 22nd, 2011, 12:55 a.m., Sebastian K=C3=BCgler wrote:

Review request for kdelibs.

By Sebastian K=C3=BCgler.

Updated Oct. 22, 2011, 12:55 a.m.

Descripti= on

This patch allows previewjobs to take a URL in case they und=
erstand how to deal with that. preview plugis can specify a list of protoco=
ls which they support, this is then matched with the scheme of the URL and =
if supported the URL is passed directly into the plugin. Otherwise, the fil=
e is downloaded and passed as local file (this part hasn't changed).

A suitable preview plugin that does the job will be submitted separately to=
 kde-runtime.

Is this definitively Frameworks 5 material, or would you be OK with adding =
it to the 4.7 branch? (The latter would mean, we could use vanilla kdelibs =
for Plasma Active 2 in december.)

Testing <= /h1>

Generating preview for HTTP URLs, for local files and for re=
mote files without a suitable plugin.

Diffs=

kdecore/services/kservice.h (040507c)
kio/kio/previewjob.cpp (ff6d340)

--===============7680838567537789913==--