From kde-core-devel Wed Nov 09 22:32:03 2011 From: "Commit Hook" Date: Wed, 09 Nov 2011 22:32:03 +0000 To: kde-core-devel Subject: Re: Review Request: Make mouse cursor size configurable Message-Id: <20111109223203.9007.76374 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=132092954123034 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2817959939896860944==" --===============2817959939896860944== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101701/#review8071 ----------------------------------------------------------- This review has been submitted with commit 617b08f5f6652bb9d918abc963954723= caca59d2 by Lukas Sommer to branch master. - Commit Hook On Sept. 2, 2011, 4:40 p.m., Lukas Sommer wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101701/ > ----------------------------------------------------------- > = > (Updated Sept. 2, 2011, 4:40 p.m.) > = > = > Review request for KDE Base Apps, KDE Runtime, kdelibs, and Christoph Fec= k. > = > = > Description > ------- > = > X11 mouse cursor themes can contain cursors in multiple sizes, making the= m pseudo-scalable. > = > It is yet possible in KDE to configure manually the mouse cursor size (ed= iting kcminput.rc). However, the GUI of the corresponding KControl module d= idn't provide support to change this. This patch add support for changing t= he mouse cursor size to the GUI. > = > This are mostly GUI related changes. The underlying data structure XCurso= rTheme did yet provide support for choosing different sizes and only needed= some adjustments. > = > = > This addresses bug 90444. > http://bugs.kde.org/show_bug.cgi?id=3D90444 > = > = > Diffs > ----- > = > kcontrol/input/xcursor/cursortheme.h 586ccba = > kcontrol/input/xcursor/cursortheme.cpp 92abea5 = > kcontrol/input/xcursor/legacytheme.h 846bf9b = > kcontrol/input/xcursor/previewwidget.h f4d2c4e = > kcontrol/input/xcursor/previewwidget.cpp 3c264fc = > kcontrol/input/xcursor/themepage.h 38ca893 = > kcontrol/input/xcursor/themepage.cpp 6c9f29a = > kcontrol/input/xcursor/themepage.ui 2e38054 = > kcontrol/input/xcursor/xcursortheme.h b474086 = > kcontrol/input/xcursor/xcursortheme.cpp 2ecb9ba = > = > Diff: http://git.reviewboard.kde.org/r/101701/diff/diff > = > = > Testing > ------- > = > Tested locally. Works fine for me. Also when using non-standard font DPI = values. > = > = > Screenshots > ----------- > = > = > http://git.reviewboard.kde.org/r/101701/s/248/ > = > = > Thanks, > = > Lukas Sommer > = > --===============2817959939896860944== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101701/ 

This revie=
w has been submitted with commit 617b08f5f6652bb9d918abc963954723caca59d2 b=
y Lukas Sommer to branch master.

- Commit


On September 2nd, 2011, 4:40 p.m., Lukas Sommer wrote:

Review request for KDE Base Apps, KDE Runtime, kdelibs, and Christoph = Feck.
By Lukas Sommer.

Updated Sept. 2, 2011, 4:40 p.m.

Descripti= on 

X11 mouse cursor themes can contain cursors in multiple size=
s, making them pseudo-scalable.

It is yet possible in KDE to configure manually the mouse cursor size (edit=
ing kcminput.rc). However, the GUI of the corresponding KControl module did=
n't provide support to change this. This patch add support for changing=
 the mouse cursor size to the GUI.

This are mostly GUI related changes. The underlying data structure XCursorT=
heme did yet provide support for choosing different sizes and only needed s=
ome adjustments.

Testing <= /h1> 
Tested locally. Works fine for me. Also when using non-stand=
ard font DPI values.
Bugs: 90444

Diffs=

  • kcontrol/input/xcursor/cursortheme.h (586c= cba)
  • kcontrol/input/xcursor/cursortheme.cpp (92= abea5)
  • kcontrol/input/xcursor/legacytheme.h (846b= f9b)
  • kcontrol/input/xcursor/previewwidget.h (f4= d2c4e)
  • kcontrol/input/xcursor/previewwidget.cpp (= 3c264fc)
  • kcontrol/input/xcursor/themepage.h (38ca89= 3)
  • kcontrol/input/xcursor/themepage.cpp (6c9f= 29a)
  • kcontrol/input/xcursor/themepage.ui (2e380= 54)
  • kcontrol/input/xcursor/xcursortheme.h (b47= 4086)
  • kcontrol/input/xcursor/xcursortheme.cpp (2= ecb9ba)

View Diff

Screensho= ts

3D""
--===============2817959939896860944==--