On November 9th, 2011, 6:48 a.m., Fredrik Höglund wrote:

kcontrol/input/xcursor/cursortheme.cpp (Diff revision 2)
static int nominalCursorSize(int iconSize)
		119	pixmap = pixmap.scaled(size, Qt::KeepAspectRatio, Qt::SmoothTransformation);

Scaling a pixmap is more expensive than scaling an image. Internally it involves converting the pixmap back to an image, scaling it, and then converting the image back to a pixmap.

This is not a major issue, but it's the reason the image was scaled before it was converted to a pixmap.

On November 9th, 2011, 11:45 a.m., Lukas Sommer wrote:

The problem is that I can't drop createIcon(int size) because I need it on other places. So I would either have to copy the code to createIcon() or change the return type of createIcon to QImage. Maybe we can leave this for a later revision?

Like I said, it's not an issue that needs to be fixed now.

- Fredrik

On September 2nd, 2011, 4:40 p.m., Lukas Sommer wrote:

Review request for KDE Base Apps, KDE Runtime, kdelibs, and Christoph Feck. By Lukas Sommer. Updated Sept. 2, 2011, 4:40 p.m. Description X11 mouse cursor themes can contain cursors in multiple sizes, making them pseudo-scalable. It is yet possible in KDE to configure manually the mouse cursor size (editing kcminput.rc). However, the GUI of the corresponding KControl module didn't provide support to change this. This patch add support for changing the mouse cursor size to the GUI. This are mostly GUI related changes. The underlying data structure XCursorTheme did yet provide support for choosing different sizes and only needed some adjustments. Testing Tested locally. Works fine for me. Also when using non-standard font DPI values. Bugs: 90444 Diffs kcontrol/input/xcursor/cursortheme.h (586ccba) kcontrol/input/xcursor/cursortheme.cpp (92abea5) kcontrol/input/xcursor/legacytheme.h (846bf9b) kcontrol/input/xcursor/previewwidget.h (f4d2c4e) kcontrol/input/xcursor/previewwidget.cpp (3c264fc) kcontrol/input/xcursor/themepage.h (38ca893) kcontrol/input/xcursor/themepage.cpp (6c9f29a) kcontrol/input/xcursor/themepage.ui (2e38054) kcontrol/input/xcursor/xcursortheme.h (b474086) kcontrol/input/xcursor/xcursortheme.cpp (2ecb9ba) View Diff Screenshots