[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: KActivities requires Soprano 2.7 to compile
From: "Ralf Jung" <ralfjung-e () gmx ! de>
Date: 2011-11-09 18:58:18
Message-ID: 20111109185818.11653.9458 () vidsolbach ! de
[Download RAW message or body]
> On Nov. 7, 2011, 3:56 p.m., Ralf Jung wrote:
> > Any comment on this? The patch looks trivial, but I am still new to all=
this so I'd prefer if someone could confirm that KActivites can and should=
actually require Soprano 2.7.
> =
> Aaron J. Seigo wrote:
> it builds here with 2.6.51. so 2.7 is not required, but perhaps some =
patch level version of 2.6. in any case, this CMakeLists.txt file should no=
t be requiring 2.7 as it isn't actually required.
Okay, I will then discard this request. I do not have the time currently to=
investigate what exact patchlevel is required, and when I look at it durin=
g the next semester break, probably nobody will be using anything below sop=
rano 2.7 ;-)
- Ralf
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102893/#review7993
-----------------------------------------------------------
On Oct. 16, 2011, 10:29 a.m., Ralf Jung wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102893/
> -----------------------------------------------------------
> =
> (Updated Oct. 16, 2011, 10:29 a.m.)
> =
> =
> Review request for kdelibs.
> =
> =
> Description
> -------
> =
> I tried compiling KActivities with Soprano 2.6 installed, which resulted =
in compile errors. After upgrading to Soprano 2.7, these were fixed.
> =
> I assume this means that KActivities actually requires Soprano 2.7? If th=
at's the case, IMHO attached patch should be applied to detect that at cmak=
e-time. (I also hope this is the right list, there is no "kactivities" grou=
p in reviewboard)
> =
> =
> Diffs
> -----
> =
> service/CMakeLists.txt 5489b6b =
> =
> Diff: http://git.reviewboard.kde.org/r/102893/diff/diff
> =
> =
> Testing
> -------
> =
> compile-tested
> =
> =
> Thanks,
> =
> Ralf Jung
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102893/">http://git.reviewboard.kde.org/r/102893/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 7th, 2011, 3:56 p.m., <b>Ralf Jung</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Any comment \
on this? The patch looks trivial, but I am still new to all this so I'd prefer if \
someone could confirm that KActivites can and should actually require Soprano \
2.7.</pre> </blockquote>
<p>On November 8th, 2011, 4:16 p.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it builds here with \
2.6.51. so 2.7 is not required, but perhaps some patch level version of 2.6. in any \
case, this CMakeLists.txt file should not be requiring 2.7 as it isn't actually \
required.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Okay, I will then \
discard this request. I do not have the time currently to investigate what exact \
patchlevel is required, and when I look at it during the next semester break, \
probably nobody will be using anything below soprano 2.7 ;-)</pre> <br />
<p>- Ralf</p>
<br />
<p>On October 16th, 2011, 10:29 a.m., Ralf Jung wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Ralf Jung.</div>
<p style="color: grey;"><i>Updated Oct. 16, 2011, 10:29 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I tried compiling KActivities with Soprano 2.6 installed, which resulted \
in compile errors. After upgrading to Soprano 2.7, these were fixed.
I assume this means that KActivities actually requires Soprano 2.7? If that's the \
case, IMHO attached patch should be applied to detect that at cmake-time. (I also \
hope this is the right list, there is no "kactivities" group in \
reviewboard)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compile-tested</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>service/CMakeLists.txt <span style="color: grey">(5489b6b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102893/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic