[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Improved Button.qml in PlasmaComponents
From: "Mark Gaiser" <markg85 () gmail ! com>
Date: 2011-11-01 20:52:14
Message-ID: 20111101205214.20496.22941 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103020/
-----------------------------------------------------------
(Updated Nov. 1, 2011, 8:52 p.m.)
Review request for KDE Runtime, Plasma and Marco Martin.
Changes
-------
Version 2.
I addressed all issues Marco pointed out.
And the pressed function is "back". I couldn't get around it since somethin=
g had to be called when you press space ;)
Description
-------
I - quite heavily - modified the Button.qml to just look better. The list o=
f changes:
- Added myself to the copyright :p
- Added a second leftMargin to the text if an icon was used. The icon and t=
ext where a little to close.
- Added surfacePressed and renamed surface to surfaceNormal. This is done f=
or a cross fade between 2 images. Works really nice!
- Added a parallel animation for the cross fade. You just have to test this=
out! To do so, make a button and press/release it. You will see the fade e=
ffect but look carefully since it only lasts 100 milliseconds ;)
- Removed some - now obsolete - javascript code
- Fixed the Text{} to use the additional margin space when an icon is used
For the added animation. This is a crossfade and it looks really nice when =
you press/release a button.
Diffs (updated)
-----
plasma/declarativeimports/plasmacomponents/qml/Button.qml d7b62d7 =
Diff: http://git.reviewboard.kde.org/r/103020/diff/diff
Testing
-------
Made some buttons and played with them. It all seems to be working just fin=
e.
Thanks,
Mark Gaiser
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103020/">http://git.reviewboard.kde.org/r/103020/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime, Plasma and Marco Martin.</div>
<div>By Mark Gaiser.</div>
<p style="color: grey;"><i>Updated Nov. 1, 2011, 8:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Version 2.
I addressed all issues Marco pointed out.
And the pressed function is "back". I couldn't get around it since \
something had to be called when you press space ;)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I - quite heavily - modified the Button.qml to just look better. The \
list of changes:
- Added myself to the copyright :p
- Added a second leftMargin to the text if an icon was used. The icon and text where \
a little to close.
- Added surfacePressed and renamed surface to surfaceNormal. This is done for a cross \
fade between 2 images. Works really nice!
- Added a parallel animation for the cross fade. You just have to test this out! To \
do so, make a button and press/release it. You will see the fade effect but look \
carefully since it only lasts 100 milliseconds ;)
- Removed some - now obsolete - javascript code
- Fixed the Text{} to use the additional margin space when an icon is used
For the added animation. This is a crossfade and it looks really nice when you \
press/release a button.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Made some buttons and played with them. It all seems to be working just \
fine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/plasmacomponents/qml/Button.qml <span style="color: \
grey">(d7b62d7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103020/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic