[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Add fromTheme property to QIconItem in
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-11-01 15:09:47
Message-ID: 20111101150947.22227.60526 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103009/#review7802
-----------------------------------------------------------
plasma/declarativeimports/qtextracomponents/qiconitem.h
<http://git.reviewboard.kde.org/r/103009/#comment6733>
could these be automatically detected? e.g. if it can't be resolved int=
o a path to an icon, then call QIcon::fromTheme?
- Aaron J. Seigo
On Oct. 31, 2011, 9:27 p.m., Mark Gaiser wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103009/
> -----------------------------------------------------------
> =
> (Updated Oct. 31, 2011, 9:27 p.m.)
> =
> =
> Review request for KDE Runtime and Plasma.
> =
> =
> Description
> -------
> =
> Hi,
> =
> I found it very strange that QIcon::fromTheme was "just working". Sadly i=
n KDE's brand new PlasmaComponents it was simply impossible to use the syst=
em icons without using plasma to view the QML. This patch adds a property t=
o QIconItem named: "fromTheme" which allows you to get the icons from the t=
heme you currently use. This patch alone isn't helping a lot of people but =
i have a second patch ready for PlasmaComponents.Button to make use of this.
> =
> Oke to commit?
> =
> =
> Diffs
> -----
> =
> plasma/declarativeimports/qtextracomponents/qiconitem.h 9972a98 =
> plasma/declarativeimports/qtextracomponents/qiconitem.cpp d72381e =
> =
> Diff: http://git.reviewboard.kde.org/r/103009/diff/diff
> =
> =
> Testing
> -------
> =
> Tested it with a bunch of different icons in and it all just seems to wor=
k fine.
> =
> =
> Thanks,
> =
> Mark Gaiser
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103009/">http://git.reviewboard.kde.org/r/103009/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103009/diff/1/?file=39961#file39961line31" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/declarativeimports/qtextracomponents/qiconitem.h</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">31</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">Q_PROPERTY</span><span class="p">(</span><span class="n">QString</span> \
<span class="n">fromTheme</span> <span class="n">WRITE</span> <span \
class="n">setIcon</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">could these \
be automatically detected? e.g. if it can't be resolved into a path to an icon, \
then call QIcon::fromTheme?</pre> </div>
<br />
<p>- Aaron J.</p>
<br />
<p>On October 31st, 2011, 9:27 p.m., Mark Gaiser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime and Plasma.</div>
<div>By Mark Gaiser.</div>
<p style="color: grey;"><i>Updated Oct. 31, 2011, 9:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hi,
I found it very strange that QIcon::fromTheme was "just working". Sadly in \
KDE's brand new PlasmaComponents it was simply impossible to use the system icons \
without using plasma to view the QML. This patch adds a property to QIconItem named: \
"fromTheme" which allows you to get the icons from the theme you currently \
use. This patch alone isn't helping a lot of people but i have a second patch \
ready for PlasmaComponents.Button to make use of this.
Oke to commit?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested it with a bunch of different icons in and it all just seems to \
work fine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/qtextracomponents/qiconitem.h <span style="color: \
grey">(9972a98)</span></li>
<li>plasma/declarativeimports/qtextracomponents/qiconitem.cpp <span style="color: \
grey">(d72381e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103009/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic