This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103009/

Review request for KDE Runtime and Plasma.
By Mark Gaiser.

Updated Oct. 31, 2011, 9:27 p.m.

Description

Hi,

I found it very strange that QIcon::fromTheme was "just working". Sadly in KDE's brand new PlasmaComponents it was simply impossible to use the system icons without using plasma to view the QML. This patch adds a property to QIconItem named: "fromTheme" which allows you to get the icons from the theme you currently use. This patch alone isn't helping a lot of people but i have a second patch ready for PlasmaComponents.Button to make use of this.

Oke to commit?

Testing

Tested it with a bunch of different icons in and it all just seems to work fine.

Diffs

  • plasma/declarativeimports/qtextracomponents/qiconitem.h (9972a98)
  • plasma/declarativeimports/qtextracomponents/qiconitem.cpp (d72381e)

View Diff