From kde-core-devel Mon Oct 31 21:27:51 2011 From: "Mark Gaiser" Date: Mon, 31 Oct 2011 21:27:51 +0000 To: kde-core-devel Subject: Re: Review Request: Add fromTheme property to QIconItem in Message-Id: <20111031212751.5573.37488 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=132009653629848 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3558546455323236510==" --===============3558546455323236510== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103009/ ----------------------------------------------------------- (Updated Oct. 31, 2011, 9:27 p.m.) Review request for KDE Runtime and Plasma. Description ------- Hi, I found it very strange that QIcon::fromTheme was "just working". Sadly in = KDE's brand new PlasmaComponents it was simply impossible to use the system= icons without using plasma to view the QML. This patch adds a property to = QIconItem named: "fromTheme" which allows you to get the icons from the the= me you currently use. This patch alone isn't helping a lot of people but i = have a second patch ready for PlasmaComponents.Button to make use of this. Oke to commit? Diffs ----- plasma/declarativeimports/qtextracomponents/qiconitem.h 9972a98 = plasma/declarativeimports/qtextracomponents/qiconitem.cpp d72381e = Diff: http://git.reviewboard.kde.org/r/103009/diff/diff Testing ------- Tested it with a bunch of different icons in and it all just seems to work = fine. Thanks, Mark Gaiser --===============3558546455323236510== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103009/

Review request for KDE Runtime and Plasma.

By Mark Gaiser.

Updated Oct. 31, 2011, 9:27 p.m.

Descripti= on

Hi,

I found it very strange that QIcon::fromTheme was "just working".=
 Sadly in KDE's brand new PlasmaComponents it was simply impossible to =
use the system icons without using plasma to view the QML. This patch adds =
a property to QIconItem named: "fromTheme" which allows you to ge=
t the icons from the theme you currently use. This patch alone isn't he=
lping a lot of people but i have a second patch ready for PlasmaComponents.=
Button to make use of this.

Oke to commit?

Testing <= /h1>

Tested it with a bunch of different icons in and it all just=
 seems to work fine.

Diffs=

plasma/declarativeimports/qtextracomponents/qiconitem.h (9972a98)
plasma/declarativeimports/qtextracomponents/qiconitem.cpp (d72381e)

--===============3558546455323236510==--