[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Fix for MMB paste on Konqueror tabs
From:       "Commit Hook" <null () kde ! org>
Date:       2011-10-31 18:31:30
Message-ID: 20111031183130.16221.30836 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102931/#review7779
-----------------------------------------------------------


This review has been submitted with commit 934607bda94cae74531d1ea4628b6cc0e38de01e by Dawit \
Alemayehu to branch master.

- Commit Hook


On Oct. 25, 2011, 3:06 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102931/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2011, 3:06 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Description
> -------
> 
> This patch addresses the bug report listed above by ignoring MMB paste requests for non-valid \
> URLs, including the internal "error://" protocol. 
> 
> This addresses bug 157753.
> http://bugs.kde.org/show_bug.cgi?id=157753
> 
> 
> Diffs
> -----
> 
> konqueror/src/konqmisc.cpp c46dc07 
> konqueror/src/konqtabs.cpp d627fad 
> 
> Diff: http://git.reviewboard.kde.org/r/102931/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
> 


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102931/">http://git.reviewboard.kde.org/r/102931/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit \
934607bda94cae74531d1ea4628b6cc0e38de01e by Dawit Alemayehu to branch master.</pre>  <br />







<p>- Commit</p>


<br />
<p>On October 25th, 2011, 3:06 p.m., Dawit Alemayehu wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for KDE Base Apps and David Faure.</div>
<div>By Dawit Alemayehu.</div>


<p style="color: grey;"><i>Updated Oct. 25, 2011, 3:06 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch addresses \
the bug report listed above by ignoring MMB paste requests for non-valid URLs, including the \
internal &quot;error://&quot; protocol.</pre>  </td>
 </tr>
</table>




<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=157753">157753</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>konqueror/src/konqmisc.cpp <span style="color: grey">(c46dc07)</span></li>

 <li>konqueror/src/konqtabs.cpp <span style="color: grey">(d627fad)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102931/diff/" style="margin-left: 3em;">View \
Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic