'Re: Review Request: Cleanup the use of HTTPProtocol::httpClose'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Cleanup the use of HTTPProtocol::httpClose
From:       "Dawit Alemayehu" <adawit () kde ! org>
Date:       2011-10-25 15:55:03
Message-ID: 20111025155503.29174.44293 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102801/
-----------------------------------------------------------

(Updated Oct. 25, 2011, 3:55 p.m.)


Review request for kdelibs and Andreas Hartmetz.


Changes
-------

Updated patch


Description
-------

This patch cleans up where and under what circumstances httpClose gets call=
ed. This is done to avoid unnecessary invocation of httpClose. With this pa=
tch the function will only get called under the following circumstances:

#1. from functions that only call proceedUntilResponseHeader directly.
#2. from proceedUntilResponseContent.
#3. from error
#4. from davFinished.

The main purpose of this change is to avoid httpClose being called multiple=
 times on every GET request which is by far the most invoked call.


Diffs (updated)
-----

  kioslave/http/http.h 4c62841 =

  kioslave/http/http.cpp 235ce7d =


Diff: http://git.reviewboard.kde.org/r/102801/diff/diff


Testing
-------


Thanks,

Dawit Alemayehu


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102801/">http://git.reviewboard.kde.org/r/102801/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs and Andreas Hartmetz.</div>
<div>By Dawit Alemayehu.</div>


<p style="color: grey;"><i>Updated Oct. 25, 2011, 3:55 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Updated patch</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch cleans up where and under what circumstances httpClose gets \
called. This is done to avoid unnecessary invocation of httpClose. With this patch \
the function will only get called under the following circumstances:

#1. from functions that only call proceedUntilResponseHeader directly.
#2. from proceedUntilResponseContent.
#3. from error
#4. from davFinished.

The main purpose of this change is to avoid httpClose being called multiple times on \
every GET request which is by far the most invoked call.</pre>  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kioslave/http/http.h <span style="color: grey">(4c62841)</span></li>

 <li>kioslave/http/http.cpp <span style="color: grey">(235ce7d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102801/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic