'Re: Review Request: Add KIO::http_delete'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Add KIO::http_delete
From:       "Dawit Alemayehu" <adawit () kde ! org>
Date:       2011-10-25 15:03:04
Message-ID: 20111025150304.26248.50471 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102938/
-----------------------------------------------------------

(Updated Oct. 25, 2011, 3:03 p.m.)


Review request for kdelibs and David Faure.


Changes
-------

Updated testing done


Description
-------

This patch adds a new KIO API, KIO::http_delete that is used to send delete=
 requests to the HTTP ioslave. This API is necessary because the HTTP proto=
col requires redirection support which is only available in KIO::TransferJo=
b. Unfortunately, none of the existing delete functions, KIO::file_delete a=
nd KIO::del, inherit from TransferJob. Hence the need for the addition of t=
his new API.


Diffs
-----

  kio/kio/accessmanager.cpp b6bb9cd =

  kio/kio/job.h 53edb90 =

  kio/kio/job.cpp 6ccb442 =


Diff: http://git.reviewboard.kde.org/r/102938/diff/diff


Testing (updated)
-------

Tested using http://www.mnot.net/javascript/xmlhttprequest/.


Thanks,

Dawit Alemayehu


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102938/">http://git.reviewboard.kde.org/r/102938/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs and David Faure.</div>
<div>By Dawit Alemayehu.</div>


<p style="color: grey;"><i>Updated Oct. 25, 2011, 3:03 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Updated testing done</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds a new KIO API, KIO::http_delete that is used to send \
delete requests to the HTTP ioslave. This API is necessary because the HTTP protocol \
requires redirection support which is only available in KIO::TransferJob. \
Unfortunately, none of the existing delete functions, KIO::file_delete and KIO::del, \
inherit from TransferJob. Hence the need for the addition of this new API.</pre>  \
</td>  </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested using http://www.mnot.net/javascript/xmlhttprequest/.</pre>  \
</td>  </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kio/kio/accessmanager.cpp <span style="color: grey">(b6bb9cd)</span></li>

 <li>kio/kio/job.h <span style="color: grey">(53edb90)</span></li>

 <li>kio/kio/job.cpp <span style="color: grey">(6ccb442)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102938/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic