[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Fix audioCD properties with solid udisks backend
From: "Commit Hook" <null () kde ! org>
Date: 2011-10-16 17:51:28
Message-ID: 20111016175128.28064.10994 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102892/#review7399
-----------------------------------------------------------
This review has been submitted with commit 3e9f380214a1619ef32aa8f8f04f5089ee53fcb9 by Lukas \
Tinkl to branch frameworks.
- Commit Hook
On Oct. 16, 2011, 10:39 a.m., Luc Menut wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102892/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2011, 10:39 a.m.)
>
>
> Review request for kdelibs, Kevin Ottens and Lukáš Tinkl.
>
>
> Description
> -------
>
> Currently, the udisks backend provides some inaccurate informations for AudioCD.
> In audioCD.log in attachment, you can find the output of 'udev/cdrom_id', 'udisks \
> --show-info' and 'solid-hardware details' for an audioCD.
> - StorageVolume.ignored is incorrectly reported as true, because "IdUsage" is empty for \
> audioCD ( (1) in the logs), so that UDisksDevice::isDeviceBlacklisted return true. To fix \
> this, I add an exception for audioCD (when OpticalDiscNumAudioTracks >0) like for empty \
> opticaldisc.
> - OpticalDisc.availableContent = 'Audio|Data' for CDDA (which don't contain any data tracks), \
> because the udev's prop ID_CDROM_MEDIA_TRACK_COUNT counts all the tracks ( \
> http://hal.freedesktop.org/docs/udisks/Device.html#Device:OpticalDiscNumTracks ) and not only \
> the number of data tracks (the number of data tracks is available in udev's \
> ID_CDROM_MEDIA_TRACK_COUNT_DATA, but currently this property isn't used by udisks). \
> Consequently, in OpticalDisc::availableContent(), hasData should be true only if \
> OpticalDiscNumTracks > OpticalDiscNumAudioTracks ( (2) in log).
> regards,
> Luc Menut
> Mageia Contributor
>
> PS: I don't have write access to kde git, so could you commit the change for me if the patch \
> looks fine. Thanks.
>
> This addresses bugs 265870 and 280229.
> http://bugs.kde.org/show_bug.cgi?id=265870
> http://bugs.kde.org/show_bug.cgi?id=280229
>
>
> Diffs
> -----
>
> solid/solid/backends/udisks/udisksdevice.cpp c76eebc
> solid/solid/backends/udisks/udisksopticaldisc.cpp 378195c
>
> Diff: http://git.reviewboard.kde.org/r/102892/diff/diff
>
>
> Testing
> -------
>
> tested with KDE 4.7.2 (Mageia Cauldron)
>
>
> Thanks,
>
> Luc Menut
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102892/">http://git.reviewboard.kde.org/r/102892/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit \
3e9f380214a1619ef32aa8f8f04f5089ee53fcb9 by Lukas Tinkl to branch frameworks.</pre> <br />
<p>- Commit</p>
<br />
<p>On October 16th, 2011, 10:39 a.m., Luc Menut wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kdelibs, Kevin Ottens and Lukáš Tinkl.</div>
<div>By Luc Menut.</div>
<p style="color: grey;"><i>Updated Oct. 16, 2011, 10:39 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently, the udisks \
backend provides some inaccurate informations for AudioCD. In audioCD.log in attachment, you \
can find the output of 'udev/cdrom_id', 'udisks --show-info' and \
'solid-hardware details' for an audioCD.
- StorageVolume.ignored is incorrectly reported as true, because "IdUsage" is empty \
for audioCD ( (1) in the logs), so that UDisksDevice::isDeviceBlacklisted return true. To fix \
this, I add an exception for audioCD (when OpticalDiscNumAudioTracks >0) like for empty \
opticaldisc.
- OpticalDisc.availableContent = 'Audio|Data' for CDDA (which don't contain any \
data tracks), because the udev's prop ID_CDROM_MEDIA_TRACK_COUNT counts all the tracks ( \
http://hal.freedesktop.org/docs/udisks/Device.html#Device:OpticalDiscNumTracks ) and not only \
the number of data tracks (the number of data tracks is available in udev's \
ID_CDROM_MEDIA_TRACK_COUNT_DATA, but currently this property isn't used by udisks). \
Consequently, in OpticalDisc::availableContent(), hasData should be true only if \
OpticalDiscNumTracks > OpticalDiscNumAudioTracks ( (2) in log).
regards,
Luc Menut
Mageia Contributor
PS: I don't have write access to kde git, so could you commit the change for me if the \
patch looks fine. Thanks.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tested with KDE 4.7.2 \
(Mageia Cauldron)</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=265870">265870</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=280229">280229</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>solid/solid/backends/udisks/udisksdevice.cpp <span style="color: \
grey">(c76eebc)</span></li>
<li>solid/solid/backends/udisks/udisksopticaldisc.cpp <span style="color: \
grey">(378195c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102892/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic