[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: facePerm is a KDM option,
From: "Ralf Jung" <ralfjung-e () gmx ! de>
Date: 2011-10-12 16:55:18
Message-ID: 20111012165518.23435.98065 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102799/
-----------------------------------------------------------
(Updated Oct. 12, 2011, 4:55 p.m.)
Review request for KDE Base Apps.
Changes
-------
Removed unnecessary whitespace changes, and the new "Remove image" button (I will \
create a separate request for it).
I always used the coding style of the function I changed, the file contains a mixture \
of tabs and 2-whitespace indents. What is the kdelibs style?
Description
-------
Currently, the "User account & password" KCM refuses to change the user image if KDM \
is set up not to use user images. That however does not make much sense, all this \
applet does is writing the image to ~/.face.icon, which the user can do manually \
anyway. The fact that KDM might or might not actually display this image in the user \
selection is unrelated, as KDM is not even the only user of this file: Plasma Kickoff \
displays it, and maybe more apps use it (GDM uses a different file, though)
This patch therefore removes the check for the KDM settings and makes the KCM simply \
manage the .face.icon file. It does not fall back to the system default if the user \
image does not exist, as Plasma Kickoff does not do that either. The patch also adds \
a button in the "Change face" dialogue to remove the user image, to make it possible \
to go back to the default state again.
After changing the image, the user still has to log off and on again for Plasma to \
use it - Plasma would have to somehow listen to changes to that file. I don't know if \
that is desired.
This addresses bug 183245.
http://bugs.kde.org/show_bug.cgi?id=183245
Diffs (updated)
-----
kdepasswd/kcm/main.h 320126f
kdepasswd/kcm/main.cpp 5ce1961
Diff: http://git.reviewboard.kde.org/r/102799/diff/diff
Testing
-------
Compiled and verified that the KCM now behaves as desired.
Thanks,
Ralf Jung
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102799/">http://git.reviewboard.kde.org/r/102799/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Ralf Jung.</div>
<p style="color: grey;"><i>Updated Oct. 12, 2011, 4:55 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Removed unnecessary whitespace changes, and the new "Remove \
image" button (I will create a separate request for it).
I always used the coding style of the function I changed, the file contains a mixture \
of tabs and 2-whitespace indents. What is the kdelibs style?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently, the "User account & password" KCM refuses to \
change the user image if KDM is set up not to use user images. That however does not \
make much sense, all this applet does is writing the image to ~/.face.icon, which the \
user can do manually anyway. The fact that KDM might or might not actually display \
this image in the user selection is unrelated, as KDM is not even the only user of \
this file: Plasma Kickoff displays it, and maybe more apps use it (GDM uses a \
different file, though)
This patch therefore removes the check for the KDM settings and makes the KCM simply \
manage the .face.icon file. It does not fall back to the system default if the user \
image does not exist, as Plasma Kickoff does not do that either. The patch also adds \
a button in the "Change face" dialogue to remove the user image, to make it \
possible to go back to the default state again.
After changing the image, the user still has to log off and on again for Plasma to \
use it - Plasma would have to somehow listen to changes to that file. I don't \
know if that is desired.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled and verified that the KCM now behaves as desired.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=183245">183245</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kdepasswd/kcm/main.h <span style="color: grey">(320126f)</span></li>
<li>kdepasswd/kcm/main.cpp <span style="color: grey">(5ce1961)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102799/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic