[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: facePerm is a KDM option,
From: "Christoph Feck" <christoph () maxiom ! de>
Date: 2011-10-09 9:22:55
Message-ID: 20111009092255.2727.12425 () vidsolbach ! de
[Download RAW message or body]
> On Oct. 8, 2011, 10:48 p.m., Gary L. Greene Jr wrote:
> > As someone that works with NFS home directory systems with autofs much of the \
> > time, I find the use of an icon in the users home directory (especially on \
> > default configurations that tend to display many users on KDM) a very bad idea. \
> > Please, lets move these to /var/tmp/kdecache-$USERNAME instead.
A cache is temporary, it could be deleted any time. Configuration files certainly \
should not be stored there.
- Christoph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102799/#review7185
-----------------------------------------------------------
On Oct. 7, 2011, 11:46 a.m., Ralf Jung wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102799/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2011, 11:46 a.m.)
>
>
> Review request for KDE Base Apps.
>
>
> Description
> -------
>
> Currently, the "User account & password" KCM refuses to change the user image if \
> KDM is set up not to use user images. That however does not make much sense, all \
> this applet does is writing the image to ~/.face.icon, which the user can do \
> manually anyway. The fact that KDM might or might not actually display this image \
> in the user selection is unrelated, as KDM is not even the only user of this file: \
> Plasma Kickoff displays it, and maybe more apps use it (GDM uses a different file, \
> though)
> This patch therefore removes the check for the KDM settings and makes the KCM \
> simply manage the .face.icon file. It does not fall back to the system default if \
> the user image does not exist, as Plasma Kickoff does not do that either. The patch \
> also adds a button in the "Change face" dialogue to remove the user image, to make \
> it possible to go back to the default state again.
> After changing the image, the user still has to log off and on again for Plasma to \
> use it - Plasma would have to somehow listen to changes to that file. I don't know \
> if that is desired.
>
> This addresses bug 183245.
> http://bugs.kde.org/show_bug.cgi?id=183245
>
>
> Diffs
> -----
>
> kdepasswd/kcm/chfacedlg.h c389e49
> kdepasswd/kcm/chfacedlg.cpp a80c5af
> kdepasswd/kcm/main.h 320126f
> kdepasswd/kcm/main.cpp 5ce1961
>
> Diff: http://git.reviewboard.kde.org/r/102799/diff/diff
>
>
> Testing
> -------
>
> Compiled and verified that the KCM now behaves as desired.
>
>
> Thanks,
>
> Ralf Jung
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102799/">http://git.reviewboard.kde.org/r/102799/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 8th, 2011, 10:48 p.m., <b>Gary L. \
Greene Jr</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As someone that works with NFS home directory systems with autofs much \
of the time, I find the use of an icon in the users home directory (especially on \
default configurations that tend to display many users on KDM) a very bad idea. \
Please, lets move these to /var/tmp/kdecache-$USERNAME instead.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A cache is temporary, it \
could be deleted any time. Configuration files certainly should not be stored \
there.</pre> <br />
<p>- Christoph</p>
<br />
<p>On October 7th, 2011, 11:46 a.m., Ralf Jung wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Ralf Jung.</div>
<p style="color: grey;"><i>Updated Oct. 7, 2011, 11:46 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently, the "User account & password" KCM refuses to \
change the user image if KDM is set up not to use user images. That however does not \
make much sense, all this applet does is writing the image to ~/.face.icon, which the \
user can do manually anyway. The fact that KDM might or might not actually display \
this image in the user selection is unrelated, as KDM is not even the only user of \
this file: Plasma Kickoff displays it, and maybe more apps use it (GDM uses a \
different file, though)
This patch therefore removes the check for the KDM settings and makes the KCM simply \
manage the .face.icon file. It does not fall back to the system default if the user \
image does not exist, as Plasma Kickoff does not do that either. The patch also adds \
a button in the "Change face" dialogue to remove the user image, to make it \
possible to go back to the default state again.
After changing the image, the user still has to log off and on again for Plasma to \
use it - Plasma would have to somehow listen to changes to that file. I don't \
know if that is desired.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled and verified that the KCM now behaves as desired.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=183245">183245</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdepasswd/kcm/chfacedlg.h <span style="color: grey">(c389e49)</span></li>
<li>kdepasswd/kcm/chfacedlg.cpp <span style="color: grey">(a80c5af)</span></li>
<li>kdepasswd/kcm/main.h <span style="color: grey">(320126f)</span></li>
<li>kdepasswd/kcm/main.cpp <span style="color: grey">(5ce1961)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102799/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic