--===============3080890413571081829== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102799/#review7185 ----------------------------------------------------------- As someone that works with NFS home directory systems with autofs much of t= he time, I find the use of an icon in the users home directory (especially = on default configurations that tend to display many users on KDM) a very ba= d idea. Please, lets move these to /var/tmp/kdecache-$USERNAME instead. - Gary L. Greene Jr On Oct. 7, 2011, 11:46 a.m., Ralf Jung wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102799/ > ----------------------------------------------------------- > = > (Updated Oct. 7, 2011, 11:46 a.m.) > = > = > Review request for KDE Base Apps. > = > = > Description > ------- > = > Currently, the "User account & password" KCM refuses to change the user i= mage if KDM is set up not to use user images. That however does not make mu= ch sense, all this applet does is writing the image to ~/.face.icon, which = the user can do manually anyway. The fact that KDM might or might not actua= lly display this image in the user selection is unrelated, as KDM is not ev= en the only user of this file: Plasma Kickoff displays it, and maybe more a= pps use it (GDM uses a different file, though) > = > This patch therefore removes the check for the KDM settings and makes the= KCM simply manage the .face.icon file. It does not fall back to the system= default if the user image does not exist, as Plasma Kickoff does not do th= at either. The patch also adds a button in the "Change face" dialogue to re= move the user image, to make it possible to go back to the default state ag= ain. > = > After changing the image, the user still has to log off and on again for = Plasma to use it - Plasma would have to somehow listen to changes to that f= ile. I don't know if that is desired. > = > = > This addresses bug 183245. > http://bugs.kde.org/show_bug.cgi?id=3D183245 > = > = > Diffs > ----- > = > kdepasswd/kcm/chfacedlg.h c389e49 = > kdepasswd/kcm/chfacedlg.cpp a80c5af = > kdepasswd/kcm/main.h 320126f = > kdepasswd/kcm/main.cpp 5ce1961 = > = > Diff: http://git.reviewboard.kde.org/r/102799/diff/diff > = > = > Testing > ------- > = > Compiled and verified that the KCM now behaves as desired. > = > = > Thanks, > = > Ralf Jung > = > --===============3080890413571081829== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102799/ 

As someone=
 that works with NFS home directory systems with autofs much of the time, I=
 find the use of an icon in the users home directory (especially on default=
 configurations that tend to display many users on KDM) a very bad idea. Pl=
ease, lets move these to /var/tmp/kdecache-$USERNAME instead.

- Gary L. Greene


On October 7th, 2011, 11:46 a.m., Ralf Jung wrote:

Review request for KDE Base Apps.
By Ralf Jung.

Updated Oct. 7, 2011, 11:46 a.m.

Descripti= on 

Currently, the "User account & password" KCM r=
efuses to change the user image if KDM is set up not to use user images. Th=
at however does not make much sense, all this applet does is writing the im=
age to ~/.face.icon, which the user can do manually anyway. The fact that K=
DM might or might not actually display this image in the user selection is =
unrelated, as KDM is not even the only user of this file: Plasma Kickoff di=
splays it, and maybe more apps use it (GDM uses a different file, though)

This patch therefore removes the check for the KDM settings and makes the K=
CM simply manage the .face.icon file. It does not fall back to the system d=
efault if the user image does not exist, as Plasma Kickoff does not do that=
 either. The patch also adds a button in the "Change face" dialog=
ue to remove the user image, to make it possible to go back to the default =
state again.

After changing the image, the user still has to log off and on again for Pl=
asma to use it - Plasma would have to somehow listen to changes to that fil=
e. I don't know if that is desired.

Testing <= /h1> 
Compiled and verified that the KCM now behaves as desired.
Bugs: 183245

Diffs=

  • kdepasswd/kcm/chfacedlg.h (c389e49)=
  • kdepasswd/kcm/chfacedlg.cpp (a80c5af)
  • kdepasswd/kcm/main.h (320126f)
  • kdepasswd/kcm/main.cpp (5ce1961)

View Diff
--===============3080890413571081829==--