[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: kfileplaceeditdialog lineedit too small
From: "David Faure" <faure () kde ! org>
Date: 2011-10-05 11:30:40
Message-ID: 20111005113040.15497.65706 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102751/#review7117
-----------------------------------------------------------
Why the setMaxLength?? What if one wants to type in a long URL?
Also, I can't reproduce the bug here (kde-4.7), but maybe only because the big icon \
button makes the dialog quite large?
- David Faure
On Oct. 4, 2011, 8:02 p.m., Greg T wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102751/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2011, 8:02 p.m.)
>
>
> Review request for Dolphin and kdelibs.
>
>
> Description
> -------
>
> Hi, this patch sets a minimum size for the widget.
>
>
> This addresses bug 266435.
> http://bugs.kde.org/show_bug.cgi?id=266435
>
>
> Diffs
> -----
>
> kfile/kfileplaceeditdialog.cpp d798b4d
>
> Diff: http://git.reviewboard.kde.org/r/102751/diff/diff
>
>
> Testing
> -------
>
> it's working
>
>
> Thanks,
>
> Greg T
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102751/">http://git.reviewboard.kde.org/r/102751/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why the setMaxLength?? \
What if one wants to type in a long URL?
Also, I can't reproduce the bug here (kde-4.7), but maybe only because the big \
icon button makes the dialog quite large?</pre> <br />
<p>- David</p>
<br />
<p>On October 4th, 2011, 8:02 p.m., Greg T wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin and kdelibs.</div>
<div>By Greg T.</div>
<p style="color: grey;"><i>Updated Oct. 4, 2011, 8:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hi, this patch sets a minimum size for the widget. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">it's working</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=266435">266435</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kfile/kfileplaceeditdialog.cpp <span style="color: grey">(d798b4d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102751/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic